diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-05-23 15:29:17 -0500 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2019-05-24 07:59:19 +0200 |
| commit | 92bfa664ae133d13a3496f71f5c7c7f4d4827a88 (patch) | |
| tree | 43cfb2db02e4df87955b5e9f2c8e94df51b712fc /sound/core | |
| parent | 947b437e1263c81bb5d30a84f1a4a35dbb9f6b78 (diff) | |
ALSA: pcm: oss: Use struct_size() helper
Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes, in particular in the
context in which this code is being used.
So, replace the following form:
sizeof(struct rate_priv) + src_format->channels * sizeof(struct rate_channel)
with:
struct_size(data, channels, src_format->channels)
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/core')
| -rw-r--r-- | sound/core/oss/rate.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sound/core/oss/rate.c b/sound/core/oss/rate.c index 2fa9299a440d..7cd09cef6961 100644 --- a/sound/core/oss/rate.c +++ b/sound/core/oss/rate.c @@ -323,8 +323,8 @@ int snd_pcm_plugin_build_rate(struct snd_pcm_substream *plug, err = snd_pcm_plugin_build(plug, "rate conversion", src_format, dst_format, - sizeof(struct rate_priv) + - src_format->channels * sizeof(struct rate_channel), + struct_size(data, channels, + src_format->channels), &plugin); if (err < 0) return err; |