diff options
author | Steven Price <steven.price@arm.com> | 2019-10-09 10:44:55 +0100 |
---|---|---|
committer | Rob Herring <robh@kernel.org> | 2019-10-09 13:36:56 -0500 |
commit | de89212ddb3dc87152dd6f2b88a20d5176156777 (patch) | |
tree | 0879ab934884eaa0a6a8a65cc5e5bff61be0c81c /drivers/phy | |
parent | 603e398a3db258bd99020e9fbabe6c624f08b942 (diff) |
drm/panfrost: Handle resetting on timeout better
Panfrost uses multiple schedulers (one for each slot, so 2 in reality),
and on a timeout has to stop all the schedulers to safely perform a
reset. However more than one scheduler can trigger a timeout at the same
time. This race condition results in jobs being freed while they are
still in use.
When stopping other slots use cancel_delayed_work_sync() to ensure that
any timeout started for that slot has completed. Also use
mutex_trylock() to obtain reset_lock. This means that only one thread
attempts the reset, the other threads will simply complete without doing
anything (the first thread will wait for this in the call to
cancel_delayed_work_sync()).
While we're here and since the function is already dependent on
sched_job not being NULL, let's remove the unnecessary checks.
Fixes: aa20236784ab ("drm/panfrost: Prevent concurrent resets")
Tested-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Steven Price <steven.price@arm.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20191009094456.9704-1-steven.price@arm.com
Diffstat (limited to 'drivers/phy')
0 files changed, 0 insertions, 0 deletions