diff options
author | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2020-07-22 16:50:57 +0100 |
---|---|---|
committer | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2020-08-31 10:47:52 +0100 |
commit | a661b571e3682705cb402a5cd1e970586a3ec00f (patch) | |
tree | 9be3ee02e0b6239b09c4644864f2ebf63736aee9 /drivers/iio/adc/ina2xx-adc.c | |
parent | 54f82df2ba86e2a8e9cbf4036d192366e3905c89 (diff) |
iio:adc:ti-adc084s021 Fix alignment and data leak issues.
One of a class of bugs pointed out by Lars in a recent review.
iio_push_to_buffers_with_timestamp assumes the buffer used is aligned
to the size of the timestamp (8 bytes). This is not guaranteed in
this driver which uses an array of smaller elements on the stack.
As Lars also noted this anti pattern can involve a leak of data to
userspace and that indeed can happen here. We close both issues by
moving to a suitable structure in the iio_priv().
This data is allocated with kzalloc so no data can leak apart from
previous readings.
The force alignment of ts is not strictly necessary in this case
but reduces the fragility of the code.
Fixes: 3691e5a69449 ("iio: adc: add driver for the ti-adc084s021 chip")
Reported-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: MÃ¥rten Lindahl <martenli@axis.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: <Stable@vger.kernel.org>
Diffstat (limited to 'drivers/iio/adc/ina2xx-adc.c')
0 files changed, 0 insertions, 0 deletions