summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSam Muhammed <jane.pnx9@gmail.com>2020-03-22 07:50:51 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-03-23 11:41:02 +0100
commitbb351cf437f586ee90ce66ccc4a23da25a3b2364 (patch)
tree6d12b6125a32fbf3f0594975d59b95df978decc7
parent38ef48f7d4b7342f145a1b4f96023bde99aeb245 (diff)
Staging: hp: Use netdev_warn().
This replaces printk(KERN_WARNING ..) with netdev_warn(), as the use of printk() isn't preferred when a struct net_device is available. Signed-off-by: Sam Muhammed <jane.pnx9@gmail.com> Acked-by: Julia Lawall <julia.lawall@inria.fr> Link: https://lore.kernel.org/r/20200322115051.2767-1-jane.pnx9@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/hp/hp100.c10
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp/hp100.c
index b89c4dcf53f5..c1f5506b7381 100644
--- a/drivers/staging/hp/hp100.c
+++ b/drivers/staging/hp/hp100.c
@@ -469,8 +469,8 @@ static int hp100_probe1(struct net_device *dev, int ioaddr, u_char bus,
eid = hp100_read_id(ioaddr);
if (eid == NULL) { /* bad checksum? */
- printk(KERN_WARNING "%s: bad ID checksum at base port 0x%x\n",
- __func__, ioaddr);
+ netdev_warn(dev, "bad ID checksum at base port 0x%x\n",
+ ioaddr);
goto out2;
}
@@ -478,9 +478,9 @@ static int hp100_probe1(struct net_device *dev, int ioaddr, u_char bus,
for (i = uc = 0; i < 7; i++)
uc += hp100_inb(LAN_ADDR + i);
if (uc != 0xff) {
- printk(KERN_WARNING
- "%s: bad lan address checksum at port 0x%x)\n",
- __func__, ioaddr);
+ netdev_warn(dev,
+ "bad lan address checksum at port 0x%x)\n",
+ ioaddr);
err = -EIO;
goto out2;
}