diff options
author | Kuniyuki Iwashima <kuniyu@amazon.co.jp> | 2020-07-21 15:15:30 +0900 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-07-21 15:31:02 -0700 |
commit | f2b2c55e512879a05456eaf5de4d1ed2f7757509 (patch) | |
tree | 063ac533d4709d483b55bb5b8d3e3899c04651ea /net/ipv6/sit.c | |
parent | 6ef9dcb78046b346b5508ca1659848b136a343c2 (diff) |
udp: Copy has_conns in reuseport_grow().
If an unconnected socket in a UDP reuseport group connect()s, has_conns is
set to 1. Then, when a packet is received, udp[46]_lib_lookup2() scans all
sockets in udp_hslot looking for the connected socket with the highest
score.
However, when the number of sockets bound to the port exceeds max_socks,
reuseport_grow() resets has_conns to 0. It can cause udp[46]_lib_lookup2()
to return without scanning all sockets, resulting in that packets sent to
connected sockets may be distributed to unconnected sockets.
Therefore, reuseport_grow() should copy has_conns.
Fixes: acdcecc61285 ("udp: correct reuseport selection with connected sockets")
CC: Willem de Bruijn <willemb@google.com>
Reviewed-by: Benjamin Herrenschmidt <benh@amazon.com>
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
Acked-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/sit.c')
0 files changed, 0 insertions, 0 deletions