diff options
| author | Mike Snitzer <snitzer@redhat.com> | 2018-06-18 11:57:51 -0400 |
|---|---|---|
| committer | Mike Snitzer <snitzer@redhat.com> | 2018-06-22 14:51:11 -0400 |
| commit | 7ccdbf85d3b2237cdbdafe6a47673dbdfab4b7a2 (patch) | |
| tree | 69afe72f69b3114b8eac18d301abba1b8ac8e316 | |
| parent | f21c601a2bb319ec19eb4562eadc7797d90fd90e (diff) | |
dm thin metadata: remove needless work from __commit_transaction
Commit 5a32083d03fb5 ("dm: take care to copy the space map roots before
locking the superblock") properly removed the calls to dm_sm_root_size()
from __write_initial_superblock(). But the dm_sm_root_size() calls were
left dangling in __commit_transaction().
Fixes: 5a32083d03fb5 ("dm: take care to copy the space map roots before locking the superblock")
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
| -rw-r--r-- | drivers/md/dm-thin-metadata.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/drivers/md/dm-thin-metadata.c b/drivers/md/dm-thin-metadata.c index 36ef284ad086..72142021b5c9 100644 --- a/drivers/md/dm-thin-metadata.c +++ b/drivers/md/dm-thin-metadata.c @@ -776,7 +776,6 @@ static int __write_changed_details(struct dm_pool_metadata *pmd) static int __commit_transaction(struct dm_pool_metadata *pmd) { int r; - size_t metadata_len, data_len; struct thin_disk_superblock *disk_super; struct dm_block *sblock; @@ -797,14 +796,6 @@ static int __commit_transaction(struct dm_pool_metadata *pmd) if (r < 0) return r; - r = dm_sm_root_size(pmd->metadata_sm, &metadata_len); - if (r < 0) - return r; - - r = dm_sm_root_size(pmd->data_sm, &data_len); - if (r < 0) - return r; - r = save_sm_roots(pmd); if (r < 0) return r; |