diff options
author | Michael S. Tsirkin <mst@dev.mellanox.co.il> | 2007-05-21 19:06:54 +0300 |
---|---|---|
committer | Roland Dreier <rolandd@cisco.com> | 2007-05-21 13:41:29 -0700 |
commit | 9f81036c54ed1f860d2807c5a6aa4f2b30c21204 (patch) | |
tree | ab0eacf7aa4a78bce8aa96073678244d01c8175d /ipc/msgutil.c | |
parent | 518b1646f8a31904ca637b8df0c1e31c34a7a3c2 (diff) |
IB/cm: Improve local id allocation
The IB CM uses an idr for local id allocations, with a running counter
as start_id. This fails to generate distinct ids if
1. An id is constantly created and destroyed
2. A chunk of ids just beyond the current next_id value is occupied
This in turn leads to an increased chance of connection request being
mis-detected as a duplicate, sometimes for several retries, until
next_id gets past the block of allocated ids. This has been observed
in practice.
As a fix, remember the last id allocated and start immediately above it.
This also fixes a problem with the old code, where next_id might
overflow and become negative.
Signed-off-by: Michael S. Tsirkin <mst@dev.mellanox.co.il>
Acked-by: Sean Hefty <sean.hefty@intel.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Diffstat (limited to 'ipc/msgutil.c')
0 files changed, 0 insertions, 0 deletions