diff options
| author | Uwe Kleine-König <uwe@kleine-koenig.org> | 2023-03-10 23:41:28 +0100 |
|---|---|---|
| committer | Li Yang <leoyang.li@nxp.com> | 2023-05-30 18:58:43 -0500 |
| commit | 59272ad8d9e8ea6398a96f8c6d62da284bf2ae6e (patch) | |
| tree | ceaacaf7f7099dd194d0e5782d222606ce44d8f4 /include/linux/fsl | |
| parent | c27ea8e6325cad44c8c5bc2e8e7cc7635f358f31 (diff) | |
bus: fsl-mc: Make remove function return void
The value returned by an fsl-mc driver's remove function is mostly
ignored. (Only an error message is printed if the value is non-zero
and then device removal continues unconditionally.)
So change the prototype of the remove function to return no value. This
way driver authors are not tempted to assume that passing an error to
the upper layer is a good idea. All drivers are adapted accordingly.
There is no intended change of behaviour, all callbacks were prepared to
return 0 before.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Tested-by: Ioana Ciornei <ioana.ciornei@nxp.com> # sanity checks
Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Tested-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Li Yang <leoyang.li@nxp.com>
Diffstat (limited to 'include/linux/fsl')
| -rw-r--r-- | include/linux/fsl/mc.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/fsl/mc.h b/include/linux/fsl/mc.h index a86115bc799c..a1b3de87a3d1 100644 --- a/include/linux/fsl/mc.h +++ b/include/linux/fsl/mc.h @@ -48,7 +48,7 @@ struct fsl_mc_driver { struct device_driver driver; const struct fsl_mc_device_id *match_id_table; int (*probe)(struct fsl_mc_device *dev); - int (*remove)(struct fsl_mc_device *dev); + void (*remove)(struct fsl_mc_device *dev); void (*shutdown)(struct fsl_mc_device *dev); int (*suspend)(struct fsl_mc_device *dev, pm_message_t state); int (*resume)(struct fsl_mc_device *dev); |