diff options
| author | Colin Ian King <colin.king@canonical.com> | 2018-01-20 22:21:40 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-01-22 11:48:06 +0100 |
| commit | 783778e38e4adf9d3e1691151c0f408e8cae514a (patch) | |
| tree | ad20746447bce409f9616acbc7c34db9887154db /drivers/staging | |
| parent | 6065490a1f227c652b0b84f3c282bb8d2a40e640 (diff) | |
staging: rtl8192e: remove two redundant assignments
Clang detected two redundant assignments that can be safely removed.
The first is the removal of the duplicated assignment to pointer 'hdr',
this has already been initialized with the same value. The second is
the removal of the redundant initialization of variable 'timeout', this
assigned value is never read and the variable is reassigned a new value
a little later.
Remove both redundant assignments, cleans up clang warnings:
drivers/staging/rtl8192e/rtllib_rx.c:1305:27: warning: Value stored to
'hdr' during its initialization is never read
drivers/staging/rtl8192e/rtllib_softmac.c:1971:6: warning: Value stored
to 'timeout' during its initialization is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging')
| -rw-r--r-- | drivers/staging/rtl8192e/rtllib_rx.c | 1 | ||||
| -rw-r--r-- | drivers/staging/rtl8192e/rtllib_softmac.c | 2 |
2 files changed, 1 insertions, 2 deletions
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c index 7bc9cb131bcc..30f72d220af1 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -1317,7 +1317,6 @@ static int rtllib_rx_InfraAdhoc(struct rtllib_device *ieee, struct sk_buff *skb, bool bToOtherSTA = false; int ret = 0, i = 0; - hdr = (struct rtllib_hdr_4addr *)skb->data; fc = le16_to_cpu(hdr->frame_ctl); type = WLAN_FC_GET_TYPE(fc); stype = WLAN_FC_GET_STYPE(fc); diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c index c2b9ffba354a..919231fec09c 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac.c +++ b/drivers/staging/rtl8192e/rtllib_softmac.c @@ -1968,7 +1968,7 @@ void rtllib_sta_ps_send_pspoll_frame(struct rtllib_device *ieee) static short rtllib_sta_ps_sleep(struct rtllib_device *ieee, u64 *time) { - int timeout = ieee->ps_timeout; + int timeout; u8 dtim; struct rt_pwr_save_ctrl *pPSC = &(ieee->PowerSaveControl); |