summaryrefslogtreecommitdiff
path: root/drivers/char
diff options
context:
space:
mode:
authorRoland Dreier <rolandd@cisco.com>2008-08-19 15:01:32 -0700
committerRoland Dreier <rolandd@cisco.com>2008-08-19 15:01:32 -0700
commita77a57a1a22afc31891d95879fe3cf2ab03838b0 (patch)
tree14f0b4a4e50f4e112d3189c75357e34829d78704 /drivers/char
parentffaa5b984a9322bbd5d9a7f0814ca2ce70feebe5 (diff)
IPoIB: Fix deadlock on RTNL in ipoib_stop()
Commit c8c2afe3 ("IPoIB: Use rtnl lock/unlock when changing device flags") added a call to rtnl_lock() in ipoib_mcast_join_task(), which is run from the ipoib_workqueue. However, ipoib_stop() (which is run inside rtnl_lock()) flushes this workqueue, which leads to a deadlock if the join task is pending. Fix this by simply not flushing the workqueue from ipoib_stop(). It turns out that we really don't care about workqueue tasks running during or after ipoib_stop(), as long as we make sure to flush the workqueue before unregistering a netdev. This fixes <https://bugs.openfabrics.org/show_bug.cgi?id=1114>. Signed-off-by: Roland Dreier <rolandd@cisco.com>
Diffstat (limited to 'drivers/char')
0 files changed, 0 insertions, 0 deletions