diff options
| author | Fangrui Song <maskray@google.com> | 2020-03-25 09:42:57 -0700 |
|---|---|---|
| committer | Michael Ellerman <mpe@ellerman.id.au> | 2020-03-27 15:50:06 +1100 |
| commit | 968339fad422a58312f67718691b717dac45c399 (patch) | |
| tree | e9a1ed24795bf406606723f07d0616d3050edb59 /arch/powerpc/boot/crt0.S | |
| parent | efbc4303b255bb80ab1283794b36dd5fe1fb0ec3 (diff) | |
powerpc/boot: Delete unneeded .globl _zimage_start
.globl sets the symbol binding to STB_GLOBAL while .weak sets the
binding to STB_WEAK. GNU as let .weak override .globl since
binutils-gdb 5ca547dc2399a0a5d9f20626d4bf5547c3ccfddd (1996). Clang
integrated assembler let the last win but it may error in the future.
Since it is a convention that only one binding directive is used, just
delete .globl.
Fixes: ee9d21b3b358 ("powerpc/boot: Ensure _zimage_start is a weak symbol")
Signed-off-by: Fangrui Song <maskray@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200325164257.170229-1-maskray@google.com
Diffstat (limited to 'arch/powerpc/boot/crt0.S')
| -rw-r--r-- | arch/powerpc/boot/crt0.S | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/arch/powerpc/boot/crt0.S b/arch/powerpc/boot/crt0.S index 92608f34d312..1d83966f5ef6 100644 --- a/arch/powerpc/boot/crt0.S +++ b/arch/powerpc/boot/crt0.S @@ -44,9 +44,6 @@ p_end: .long _end p_pstack: .long _platform_stack_top #endif - .globl _zimage_start - /* Clang appears to require the .weak directive to be after the symbol - * is defined. See https://bugs.llvm.org/show_bug.cgi?id=38921 */ .weak _zimage_start _zimage_start: .globl _zimage_start_lib |