summaryrefslogtreecommitdiff
path: root/scripts
diff options
context:
space:
mode:
authorGuenter Roeck <linux@roeck-us.net>2017-08-10 21:15:40 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-08-18 15:57:15 -0700
commit3113bf1a5da35fef410f551f947f16a74d71f0a9 (patch)
treee50f176ba5f0fa49833d5387da2d49dacf35c555 /scripts
parent3c41dbde20881959998832b5b9900dfdd6fcb770 (diff)
staging: typec: tcpm: Report role swap complete after entering READY state
Role swap requests fail unless the current role is either SRC_READY or SNK_READY. This works fine for VCONN and data role swaps, where we immediately enter READY state after reporting a successful role swap to user space. However, on power role changes, the role swap is currently reported as successful while power negotiation is still in process. User space does not know this, and may request another role swap immediately after a power role swap is reported to be complete. This second role swap will fail with -EAGAIN. To fix the problem, report role swap completion after power negotiation is complete and the state machine enters SRC_READY or SNK_READY state. This is better anyway since it captures errors due to failed power negotiations. It also simplifies the code since the number of calls needed to report successful role swaps is reduced. Reported-by: Howard Yen <howard_yen@htc.com> Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions