summaryrefslogtreecommitdiff
path: root/net/rfkill
diff options
context:
space:
mode:
authorLinus Walleij <linus.walleij@linaro.org>2024-08-07 17:02:32 +0200
committerMark Brown <broonie@kernel.org>2024-08-07 23:45:16 +0100
commitc2c0b67dca3cb3b3cea0dd60075a1c5ba77e2fcd (patch)
treee8b8bc877dac2ba73d81a2e3b49ea705cb2017c6 /net/rfkill
parent7d2fb3812acde0a76e0d361877e8295db065f9f4 (diff)
ASoC: tas2781-i2c: Drop weird GPIO code
The tas2781-i2c driver gets an IRQ from either ACPI or device tree, then proceeds to check if the IRQ has a corresponding GPIO and in case it does enforce the GPIO as input and set a label on it. This is abuse of the API: - First we cannot guarantee that the numberspaces of the GPIOs and the IRQs are the same, i.e that an IRQ number corresponds to a GPIO number like that. - Second, GPIO chips and IRQ chips should be treated as orthogonal APIs, the irqchip needs to ascertain that the backing GPIO line is set to input etc just using the irqchip. - Third it is using the legacy <linux/gpio.h> API which should not be used in new code yet this was added just a year ago. Delete the offending code. If this creates problems the GPIO and irqchip maintainers can help to fix the issues. It *should* not create any problems, because the irq isn't used anywhere in the driver, it's just obtained and then left unused. Fixes: ef3bcde75d06 ("ASoC: tas2781: Add tas2781 driver") Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Link: https://patch.msgid.link/20240807-asoc-tas-gpios-v2-1-bd0f2705d58b@linaro.org Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'net/rfkill')
0 files changed, 0 insertions, 0 deletions