diff options
author | Jakub Kicinski <kuba@kernel.org> | 2022-04-07 20:38:16 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2022-04-08 11:49:08 +0100 |
commit | c3f6bb74137c68b515b7e2ff123a80611e801013 (patch) | |
tree | cdef4b7bf334b0e5c3c99d49a65fcf88682b832f /net/hsr | |
parent | d5123edd10cf9d324fcb88e276bdc7375f3c5321 (diff) |
tls: rx: don't store the record type in socket context
Original TLS implementation was handling one record at a time.
It stashed the type of the record inside tls context (per socket
structure) for convenience. When async crypto support was added
[1] the author had to use skb->cb to store the type per-message.
The use of skb->cb overlaps with strparser, however, so a hybrid
approach was taken where type is stored in context while parsing
(since we parse a message at a time) but once parsed its copied
to skb->cb.
Recently a workaround for sockmaps [2] exposed the previously
private struct _strp_msg and started a trend of adding user
fields directly in strparser's header. This is cleaner than
storing information about an skb in the context.
This change is not strictly necessary, but IMHO the ownership
of the context field is confusing. Information naturally
belongs to the skb.
[1] commit 94524d8fc965 ("net/tls: Add support for async decryption of tls records")
[2] commit b2c4618162ec ("bpf, sockmap: sk_skb data_end access incorrect when src_reg = dst_reg")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/hsr')
0 files changed, 0 insertions, 0 deletions