diff options
author | Vladimir Oltean <olteanv@gmail.com> | 2019-04-28 21:45:46 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-04-30 23:05:28 -0400 |
commit | d371b7c92d190448f3ccbf082c90bf929285f648 (patch) | |
tree | 5e2cd5d9d197a4bc2fcaf3c70ed787fed4a70320 /net/atm/lec.h | |
parent | 7228b23e68f79d96141976924983296600dc1346 (diff) |
net: dsa: Unset vlan_filtering when ports leave the bridge
When ports are standalone (after they left the bridge), they should have
no VLAN filtering semantics (they should pass all traffic to the CPU).
Currently this is not true for switchdev drivers, because the bridge
"forgets" to unset that.
Normally one would think that doing this at the bridge layer would be a
better idea, i.e. call br_vlan_filter_toggle() from br_del_if(), similar
to how nbp_vlan_init() is called from br_add_if().
However what complicates that approach, and makes this one preferable,
is the fact that for the bridge core, vlan_filtering is a per-bridge
setting, whereas for switchdev/DSA it is per-port. Also there are
switches where the setting is per the entire device, and unsetting
vlan_filtering one by one, for each leaving port, would not be possible
from the bridge core without a certain level of awareness. So do this in
DSA and let drivers be unaware of it.
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/atm/lec.h')
0 files changed, 0 insertions, 0 deletions