summaryrefslogtreecommitdiff
path: root/drivers/leds/leds-mt6323.c
diff options
context:
space:
mode:
authorRasmus Villemoes <linux@rasmusvillemoes.dk>2019-03-14 15:06:14 +0100
committerJacek Anaszewski <jacek.anaszewski@gmail.com>2019-03-30 19:09:32 +0100
commit909346433064b8d840dc82af26161926b8d37558 (patch)
treea00e6c4fe49136d7c79c2b294e441e78eb121f92 /drivers/leds/leds-mt6323.c
parent0aab8e4df4702b31314a27ec4b0631dfad0fae0a (diff)
leds: trigger: netdev: use memcpy in device_name_store
If userspace doesn't end the input with a newline (which can easily happen if the write happens from a C program that does write(fd, iface, strlen(iface))), we may end up including garbage from a previous, longer value in the device_name. For example # cat device_name # printf 'eth12' > device_name # cat device_name eth12 # printf 'eth3' > device_name # cat device_name eth32 I highly doubt anybody is relying on this behaviour, so switch to simply copying the bytes (we've already checked that size is < IFNAMSIZ) and unconditionally zero-terminate it; of course, we also still have to strip a trailing newline. This is also preparation for future patches. Fixes: 06f502f57d0d ("leds: trigger: Introduce a NETDEV trigger") Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> Acked-by: Pavel Machek <pavel@ucw.cz> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Diffstat (limited to 'drivers/leds/leds-mt6323.c')
0 files changed, 0 insertions, 0 deletions