diff options
| author | Yury Norov <yury.norov@gmail.com> | 2024-04-16 10:37:11 -0700 |
|---|---|---|
| committer | Thomas Bogendoerfer <tsbogend@alpha.franken.de> | 2024-05-03 14:22:04 +0200 |
| commit | bfe4ab93c80cc5689ab5a891e61013dfec48f56e (patch) | |
| tree | 51bf719d98e3115564768abf5199fbefda4a2d56 /arch/mips | |
| parent | 156e6498fc61157a8779a0920008cfdfa55c4a8b (diff) | |
MIPS: SGI-IP27: use WARN_ON() output
WARN_ON() propagates the result of conditional expression, and it can be
used to return early in the following expression in the arch_init_irq().
This is a no-op cleanup, except that compiler may optimize the error paths
better because WARN_ON() implies 'unlikely()'.
Signed-off-by: Yury Norov <yury.norov@gmail.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Diffstat (limited to 'arch/mips')
| -rw-r--r-- | arch/mips/sgi-ip27/ip27-irq.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/arch/mips/sgi-ip27/ip27-irq.c b/arch/mips/sgi-ip27/ip27-irq.c index d8acdf0439d2..00e63e9ef61d 100644 --- a/arch/mips/sgi-ip27/ip27-irq.c +++ b/arch/mips/sgi-ip27/ip27-irq.c @@ -289,13 +289,12 @@ void __init arch_init_irq(void) bitmap_set(hub_irq_map, NI_BRDCAST_ERR_A, MSC_PANIC_INTR - NI_BRDCAST_ERR_A + 1); fn = irq_domain_alloc_named_fwnode("HUB"); - WARN_ON(fn == NULL); - if (!fn) + if (WARN_ON(fn == NULL)) return; + domain = irq_domain_create_linear(fn, IP27_HUB_IRQ_COUNT, &hub_domain_ops, NULL); - WARN_ON(domain == NULL); - if (!domain) + if (WARN_ON(domain == NULL)) return; irq_set_default_host(domain); |