diff options
| author | Christoph Hellwig <hch@lst.de> | 2018-07-11 22:25:58 -0700 |
|---|---|---|
| committer | Darrick J. Wong <darrick.wong@oracle.com> | 2018-07-11 22:25:58 -0700 |
| commit | 91cdfd1761659f338e673aca72af3d0d50b88847 (patch) | |
| tree | 9cfb3341ddbdbe33739349a2a1ed9e6c34ba9889 | |
| parent | d43801775766972535a0f4b78af65d0c13055e36 (diff) | |
xfs: do not set the page uptodate in xfs_writepage_map
We already track the page uptodate status based on the buffer uptodate
status, which is updated whenever reading or zeroing blocks.
This code has been there since commit a ptool commit in 2002, which
claims to:
"merge" the 2.4 fsx fix for block size < page size to 2.5. This needed
major changes to actually fit.
and isn't present in other writepage implementations.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
| -rw-r--r-- | fs/xfs/xfs_aops.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 5c549e983d69..df80a383ccd8 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -849,7 +849,6 @@ xfs_writepage_map( uint64_t offset; int error = 0; int count = 0; - int uptodate = 1; unsigned int new_type; bh = head = page_buffers(page); @@ -857,8 +856,6 @@ xfs_writepage_map( do { if (offset >= end_offset) break; - if (!buffer_uptodate(bh)) - uptodate = 0; /* * set_page_dirty dirties all buffers in a page, independent @@ -922,9 +919,6 @@ xfs_writepage_map( } while (offset += len, ((bh = bh->b_this_page) != head)); - if (uptodate && bh == head) - SetPageUptodate(page); - ASSERT(wpc->ioend || list_empty(&submit_list)); out: |