diff options
| author | Tian Tao <tiantao6@hisilicon.com> | 2021-03-19 11:29:31 +0800 |
|---|---|---|
| committer | Wolfram Sang <wsa@kernel.org> | 2021-10-29 21:57:33 +0200 |
| commit | 5fe058b04d017a91cd1fa9281c57d0c3d3a34f58 (patch) | |
| tree | ab32d661107c6d4850a506e678c2554eaf5fad37 | |
| parent | 8e98c4f5c38b253adeefc3dc62d447f1fb973c77 (diff) | |
i2c: qup: move to use request_irq by IRQF_NO_AUTOEN flag
disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable because of requesting.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
| -rw-r--r-- | drivers/i2c/busses/i2c-qup.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c index 95e7c4491f09..69e9f3ecf87d 100644 --- a/drivers/i2c/busses/i2c-qup.c +++ b/drivers/i2c/busses/i2c-qup.c @@ -1797,12 +1797,12 @@ nodma: goto fail; ret = devm_request_irq(qup->dev, qup->irq, qup_i2c_interrupt, - IRQF_TRIGGER_HIGH, "i2c_qup", qup); + IRQF_TRIGGER_HIGH | IRQF_NO_AUTOEN, + "i2c_qup", qup); if (ret) { dev_err(qup->dev, "Request %d IRQ failed\n", qup->irq); goto fail; } - disable_irq(qup->irq); hw_ver = readl(qup->base + QUP_HW_VERSION); dev_dbg(qup->dev, "Revision %x\n", hw_ver); |