diff options
| author | Jiapeng Chong <jiapeng.chong@linux.alibaba.com> | 2021-12-09 14:21:22 +0800 |
|---|---|---|
| committer | Alexei Starovoitov <ast@kernel.org> | 2021-12-11 17:57:33 -0800 |
| commit | 4674f21071b935c237217ac02cb310522d6ad95d (patch) | |
| tree | ac9769e52f8beb1f498502aee04aa18b0ff47e08 | |
| parent | 84ef3f0bb72dfcdeb7ff3e5335882f6084381437 (diff) | |
bpf: Use kmemdup() to replace kmalloc + memcpy
Eliminate the follow coccicheck warning:
./kernel/bpf/btf.c:6537:13-20: WARNING opportunity for kmemdup.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/1639030882-92383-1-git-send-email-jiapeng.chong@linux.alibaba.com
| -rw-r--r-- | kernel/bpf/btf.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c index 8b00c6e4d6fb..baa90f3acd41 100644 --- a/kernel/bpf/btf.c +++ b/kernel/bpf/btf.c @@ -6534,12 +6534,11 @@ static struct bpf_cand_cache *populate_cand_cache(struct bpf_cand_cache *cands, bpf_free_cands_from_cache(*cc); *cc = NULL; } - new_cands = kmalloc(sizeof_cands(cands->cnt), GFP_KERNEL); + new_cands = kmemdup(cands, sizeof_cands(cands->cnt), GFP_KERNEL); if (!new_cands) { bpf_free_cands(cands); return ERR_PTR(-ENOMEM); } - memcpy(new_cands, cands, sizeof_cands(cands->cnt)); /* strdup the name, since it will stay in cache. * the cands->name points to strings in prog's BTF and the prog can be unloaded. */ |