diff options
author | Lv Yunlong <lyl2019@mail.ustc.edu.cn> | 2021-04-26 06:43:46 -0700 |
---|---|---|
committer | Oded Gabbay <ogabbay@kernel.org> | 2021-05-08 11:36:07 +0300 |
commit | 115726c5d312b462c9d9931ea42becdfa838a076 (patch) | |
tree | a50f50a221cd7b6819051ec50080f2f1a7416951 /include/ras/ras_event.h | |
parent | 24a107097fbd8fb6a48a0dcb31e64c1de6831a1d (diff) |
habanalabs/gaudi: Fix a potential use after free in gaudi_memset_device_memory
Our code analyzer reported a uaf.
In gaudi_memset_device_memory, cb is get via hl_cb_kernel_create()
with 2 refcount.
If hl_cs_allocate_job() failed, the execution runs into release_cb
branch. One ref of cb is dropped by hl_cb_put(cb) and could be freed
if other thread also drops one ref. Then cb is used by cb->id later,
which is a potential uaf.
My patch add a variable 'id' to accept the value of cb->id before the
hl_cb_put(cb) is called, to avoid the potential uaf.
Fixes: 423815bf02e25 ("habanalabs/gaudi: remove PCI access to SM block")
Signed-off-by: Lv Yunlong <lyl2019@mail.ustc.edu.cn>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
Diffstat (limited to 'include/ras/ras_event.h')
0 files changed, 0 insertions, 0 deletions