summaryrefslogtreecommitdiff
path: root/drivers/thermal/rzg2l_thermal.c
diff options
context:
space:
mode:
authorBiju Das <biju.das.jz@bp.renesas.com>2021-12-08 16:40:09 +0000
committerDaniel Lezcano <daniel.lezcano@linaro.org>2021-12-09 15:58:09 +0100
commit8ee1c0f6526ce942b7595951c7bb0165010051c2 (patch)
tree8efb51c88f6d08ce9887706eff3924052eb99334 /drivers/thermal/rzg2l_thermal.c
parent3de89d8842a2b5d3dd22ebf97dd561ae0a330948 (diff)
thermal/drivers/rz2gl: Add error check for reset_control_deassert()
If reset_control_deassert() fails, then we won't be able to access the device registers. Therefore check the return code of reset_control_deassert() and bail out in case of error. While at it replace the parameter "&pdev->dev" -> "dev" in devm_reset_control_get_exclusive(). Suggested-by: Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> Link: https://lore.kernel.org/r/20211208164010.4130-1-biju.das.jz@bp.renesas.com Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Diffstat (limited to 'drivers/thermal/rzg2l_thermal.c')
-rw-r--r--drivers/thermal/rzg2l_thermal.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/thermal/rzg2l_thermal.c b/drivers/thermal/rzg2l_thermal.c
index d47d4a30cd6c..7a9cdc1f37ca 100644
--- a/drivers/thermal/rzg2l_thermal.c
+++ b/drivers/thermal/rzg2l_thermal.c
@@ -170,12 +170,14 @@ static int rzg2l_thermal_probe(struct platform_device *pdev)
return PTR_ERR(priv->base);
priv->dev = dev;
- priv->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL);
+ priv->rstc = devm_reset_control_get_exclusive(dev, NULL);
if (IS_ERR(priv->rstc))
return dev_err_probe(dev, PTR_ERR(priv->rstc),
"failed to get cpg reset");
- reset_control_deassert(priv->rstc);
+ ret = reset_control_deassert(priv->rstc);
+ if (ret)
+ return dev_err_probe(dev, ret, "failed to deassert");
pm_runtime_enable(dev);
pm_runtime_get_sync(dev);