diff options
| author | Colin Ian King <colin.king@canonical.com> | 2020-12-07 14:24:10 +0000 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2020-12-11 07:42:27 -0800 |
| commit | e1d15969635ca61aa12091a53dc5d148e5621782 (patch) | |
| tree | f312d35b1e3e7836071ad32f41d4b15a28af043a /drivers/hwmon | |
| parent | 966ead9153c25ee08d14a494585df4439b210474 (diff) | |
hwmon: (ltc2992) Fix less than zero comparisons with an unsigned integer
There are several occurrances of a less than zero error check on
a u32 unsigned integer. These will never be true. Fix this by making
reg_value a plain int.
Addresses-Coverity: ("Unsigned comparison against zero")
Fixes: e126370240e0 ("hwmon: (ltc2992) Add support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20201207142410.168987-1-colin.king@canonical.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/ltc2992.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/hwmon/ltc2992.c b/drivers/hwmon/ltc2992.c index 69dbb5aa5dc2..4382105bf142 100644 --- a/drivers/hwmon/ltc2992.c +++ b/drivers/hwmon/ltc2992.c @@ -480,7 +480,7 @@ static int ltc2992_read_gpios_in(struct device *dev, u32 attr, int nr_gpio, long static int ltc2992_read_in_alarm(struct ltc2992_state *st, int channel, long *val, u32 attr) { - u32 reg_val; + int reg_val; u32 mask; if (attr == hwmon_in_max_alarm) @@ -534,7 +534,7 @@ static int ltc2992_read_in(struct device *dev, u32 attr, int channel, long *val) static int ltc2992_get_current(struct ltc2992_state *st, u32 reg, u32 channel, long *val) { - u32 reg_val; + int reg_val; reg_val = ltc2992_read_reg(st, reg, 2); if (reg_val < 0) @@ -558,7 +558,7 @@ static int ltc2992_set_current(struct ltc2992_state *st, u32 reg, u32 channel, l static int ltc2992_read_curr_alarm(struct ltc2992_state *st, int channel, long *val, u32 attr) { - u32 reg_val; + int reg_val; u32 mask; if (attr == hwmon_curr_max_alarm) @@ -609,7 +609,7 @@ static int ltc2992_read_curr(struct device *dev, u32 attr, int channel, long *va static int ltc2992_get_power(struct ltc2992_state *st, u32 reg, u32 channel, long *val) { - u32 reg_val; + int reg_val; reg_val = ltc2992_read_reg(st, reg, 3); if (reg_val < 0) @@ -633,7 +633,7 @@ static int ltc2992_set_power(struct ltc2992_state *st, u32 reg, u32 channel, lon static int ltc2992_read_power_alarm(struct ltc2992_state *st, int channel, long *val, u32 attr) { - u32 reg_val; + int reg_val; u32 mask; if (attr == hwmon_power_max_alarm) |