summaryrefslogtreecommitdiff
path: root/drivers/hid/hid-sunplus.c
diff options
context:
space:
mode:
authorMikulas Patocka <mpatocka@redhat.com>2016-07-28 18:56:13 -0400
committerBen Skeggs <bskeggs@redhat.com>2016-07-30 18:17:22 +1000
commit28668f43b8e421634e1623f72a879812288dd06b (patch)
tree27b8fb9140941d3d30ba4689240890c1fd033e28 /drivers/hid/hid-sunplus.c
parentc11dea5b0290984fa48111957ba3fdc5b3bdae5a (diff)
drm/nouveau/fbcon: fix font width not divisible by 8
The patch f045f459d925 ("drm/nouveau/fbcon: fix out-of-bounds memory accesses") tries to fix some out of memory accesses. Unfortunatelly, the patch breaks the display when using fonts with width that is not divisiable by 8. The monochrome bitmap for each character is stored in memory by lines from top to bottom. Each line is padded to a full byte. For example, for 22x11 font, each line is padded to 16 bits, so each character is consuming 44 bytes total, that is 11 32-bit words. The patch f045f459d925 changed the logic to "dsize = ALIGN(image->width * image->height, 32) >> 5", that is just 8 words - this is incorrect and it causes display corruption. This patch adds the necesary padding of lines to 8 bytes. This patch should be backported to stable kernels where f045f459d925 was backported. Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> Fixes: f045f459d925 ("drm/nouveau/fbcon: fix out-of-bounds memory accesses") Cc: stable@vger.kernel.org Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
Diffstat (limited to 'drivers/hid/hid-sunplus.c')
0 files changed, 0 insertions, 0 deletions