diff options
author | Luc Van Oostenryck <luc.vanoostenryck@gmail.com> | 2017-06-26 15:16:25 +0200 |
---|---|---|
committer | Will Deacon <will.deacon@arm.com> | 2017-06-29 11:33:01 +0100 |
commit | c0d109de4c0ca365a2bd180e2e65501196fa8ef4 (patch) | |
tree | e5f54f217c4e2b7f1d52901d7fb88214f3a72f15 | |
parent | 02129ae5fea83294b45c8f16c4ff14ae94e6858d (diff) |
arm64: use readq() instead of readl() to read 64bit entry_point
Here the entrypoint, declared as a 64 bit integer, is read from
a pointer to 64bit integer but the read is done via readl_relaxed()
which is for 32bit quantities.
All the high bits will thus be lost which change the meaning
of the test against zero done later.
Fix this by using readq_relaxed() instead as it should be for
64bit quantities.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
-rw-r--r-- | arch/arm64/kernel/acpi_parking_protocol.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/arm64/kernel/acpi_parking_protocol.c b/arch/arm64/kernel/acpi_parking_protocol.c index 1f5655cd9cc9..f35e80aad378 100644 --- a/arch/arm64/kernel/acpi_parking_protocol.c +++ b/arch/arm64/kernel/acpi_parking_protocol.c @@ -125,7 +125,7 @@ static void acpi_parking_protocol_cpu_postboot(void) struct parking_protocol_mailbox __iomem *mailbox = cpu_entry->mailbox; __le64 entry_point; - entry_point = readl_relaxed(&mailbox->entry_point); + entry_point = readq_relaxed(&mailbox->entry_point); /* * Check if firmware has cleared the entry_point as expected * by the protocol specification. |