diff options
| author | Peter Zijlstra <peterz@infradead.org> | 2020-04-21 12:09:13 +0200 |
|---|---|---|
| committer | Peter Zijlstra <peterz@infradead.org> | 2020-06-15 14:10:20 +0200 |
| commit | 4ca6c1a060943161c6c2ce09e02ed58a69669cfe (patch) | |
| tree | 48a294a80ec1e3360b0c70cce27994485d2b3090 | |
| parent | dbc6d0d5a5467adb6ea5fb25844e471c7bf8fabf (diff) | |
sched,acpi_pad: Convert to sched_set_fifo*()
Because SCHED_FIFO is a broken scheduler model (see previous patches)
take away the priority field, the kernel can't possibly make an
informed decision.
In this case, use fifo_low, because it only cares about being above
SCHED_NORMAL. Effectively no change in behaviour.
XXX: this driver is still complete crap; why isn't it using proper
idle injection or at the very least play_idle() ?
Cc: rafael.j.wysocki@intel.com
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Ingo Molnar <mingo@kernel.org>
| -rw-r--r-- | drivers/acpi/acpi_pad.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c index e7dc0133f817..0ad9f2059e6d 100644 --- a/drivers/acpi/acpi_pad.c +++ b/drivers/acpi/acpi_pad.c @@ -136,12 +136,11 @@ static unsigned int idle_pct = 5; /* percentage */ static unsigned int round_robin_time = 1; /* second */ static int power_saving_thread(void *data) { - struct sched_param param = {.sched_priority = 1}; int do_sleep; unsigned int tsk_index = (unsigned long)data; u64 last_jiffies = 0; - sched_setscheduler(current, SCHED_RR, ¶m); + sched_set_fifo_low(current); while (!kthread_should_stop()) { unsigned long expire_time; |