diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2018-01-27 15:28:28 +0100 |
|---|---|---|
| committer | Thierry Reding <treding@nvidia.com> | 2018-03-08 14:43:13 +0100 |
| commit | 1320f76897c5e4893aff68d0bfc1797a5ba543ff (patch) | |
| tree | 5c604e70a3b15165c6f46ded20c1db65e5616c9a | |
| parent | 1abb081e41a718d73183b0e1b76bfff66e92f7e1 (diff) | |
firmware: tegra: adjust tested variable
Check the variable that was most recently initialized.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression x, y, f, g, e, m;
statement S1,S2,S3,S4;
@@
x = f(...);
if (\(<+...x...+>\&e\)) S1 else S2
(
x = g(...);
|
m = g(...,&x,...);
|
y = g(...);
*if (e)
S3 else S4
)
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
| -rw-r--r-- | drivers/firmware/tegra/bpmp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/firmware/tegra/bpmp.c b/drivers/firmware/tegra/bpmp.c index 81bc2dce8626..14a456afa379 100644 --- a/drivers/firmware/tegra/bpmp.c +++ b/drivers/firmware/tegra/bpmp.c @@ -694,7 +694,7 @@ static int tegra_bpmp_probe(struct platform_device *pdev) } bpmp->rx.virt = gen_pool_dma_alloc(bpmp->rx.pool, 4096, &bpmp->rx.phys); - if (!bpmp->rx.pool) { + if (!bpmp->rx.virt) { dev_err(&pdev->dev, "failed to allocate from RX pool\n"); err = -ENOMEM; goto free_tx; |