summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLi Xi <pkuelelixi@gmail.com>2014-10-01 22:11:06 -0400
committerTheodore Ts'o <tytso@mit.edu>2014-10-01 22:11:06 -0400
commitbce92d566a57893e98ec83e4e5447f860d2889b7 (patch)
tree8fdbc6d3ea56f689c2709579bb5396ff7d396348
parentd6320cbfc92910a3e5f10c42d98c231c98db4f60 (diff)
ext4: fix return value of ext4_do_update_inode
When ext4_do_update_inode() gets error from ext4_inode_blocks_set(), error number should be returned. Signed-off-by: Li Xi <lixi@ddn.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu> Reviewed-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Jan Kara <jack@suse.cz>
-rw-r--r--fs/ext4/inode.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 091845298f48..41c4f97c39d3 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -4204,7 +4204,8 @@ static int ext4_do_update_inode(handle_t *handle,
EXT4_INODE_SET_XTIME(i_atime, inode, raw_inode);
EXT4_EINODE_SET_XTIME(i_crtime, ei, raw_inode);
- if (ext4_inode_blocks_set(handle, raw_inode, ei)) {
+ err = ext4_inode_blocks_set(handle, raw_inode, ei);
+ if (err) {
spin_unlock(&ei->i_raw_lock);
goto out_brelse;
}