diff options
author | Martin Nordholts <martinn@src.gnome.org> | 2009-12-20 09:41:07 +0100 |
---|---|---|
committer | Jonathan Corbet <corbet@lwn.net> | 2010-02-06 16:32:35 -0700 |
commit | 2d89da8864f387e236ff0d90885e47f69e59ebef (patch) | |
tree | 0c83a68e9e17242f8272119638eab0cb9e77a3dc | |
parent | 9abb7c32bbbebf228448619a3ecb8f78f6a6081f (diff) |
Move out global houskeeping from grabpatch()
As a step to make grabpatch() more unit-test friendly, move out global
houskeeping from grabpatch(). This also gets rid of a TODO in the
code. The regression tests still passes after this refactoring, of
course.
Signed-off-by: Martin Nordholts <martinn@src.gnome.org>
-rwxr-xr-x | gitdm | 37 |
1 files changed, 19 insertions, 18 deletions
@@ -145,7 +145,7 @@ class patch: # The core hack for grabbing the information about a changeset. # def grabpatch(): - global NextLine, TotalAdded, TotalRemoved, TotalChanged + global NextLine while (1): m = Pcommit.match (NextLine) @@ -250,23 +250,6 @@ def grabpatch(): if '@' in p.author.name: print '%s is an author name, probably not what you want' % p.author.name - # - # Record some global information - but only if this patch had - # stuff which wasn't ignored. This work should be done - # elsewhere, - # - if ((p.added + p.removed) > 0 or not FileFilter) and not p.merge: - TotalAdded += p.added - TotalRemoved += p.removed - TotalChanged += max (p.added, p.removed) - AddDateLines (p.date, max (p.added, p.removed)) - empl = p.author.emailemployer (p.email, p.date) - empl.AddCSet (p) - if AkpmOverLt: - TrimLTSOBs (p) - for sobemail, sobber in p.sobs: - empl = sobber.emailemployer (sobemail, p.date) - empl.AddSOB() return p @@ -340,6 +323,24 @@ while (1): # continue if FileFilter and p.added == 0 and p.removed == 0: continue + + # + # Record some global information - but only if this patch had + # stuff which wasn't ignored. + # + if ((p.added + p.removed) > 0 or not FileFilter) and not p.merge: + TotalAdded += p.added + TotalRemoved += p.removed + TotalChanged += max (p.added, p.removed) + AddDateLines (p.date, max (p.added, p.removed)) + empl = p.author.emailemployer (p.email, p.date) + empl.AddCSet (p) + if AkpmOverLt: + TrimLTSOBs (p) + for sobemail, sobber in p.sobs: + empl = sobber.emailemployer (sobemail, p.date) + empl.AddSOB() + if not p.merge: p.author.addpatch (p) for sobemail, sob in p.sobs: |