summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2015-09-28Fix documentation for spice_main_file_copy_async()HEADmasterJonathon Jongsma1-1/+1
'sources' should be a NULL-terminated array, but the parameter documentation treats it as if it is a single file object.
2015-09-25Update NEWS for 0.30 releasev0.30Jonathon Jongsma1-0/+16
2015-09-25Move glib-compat.c to POTFILES.skipJonathon Jongsma2-1/+1
Since these messages are only used for terminal debug output, let's not waste time translating them.
2015-09-25docs: Fix typosPavel Grunt6-9/+9
2015-09-25docs: Add missing symbol description stringsPavel Grunt21-14/+194
2015-09-25docs: Description should be above 'Return'Pavel Grunt1-4/+4
2015-09-25docs: Add missing parameter/field descriptionsPavel Grunt14-48/+59
2015-09-25docs: Move SPICE_TYPE_USB_DEVICE to standard subsectionPavel Grunt1-1/+1
2015-09-25docs: Add Version Information sectionPavel Grunt3-4/+11
2015-09-25docs: Update for missing symbolsPavel Grunt1-0/+10
2015-09-25channel-main: Rename parameter to match docsPavel Grunt1-2/+2
2015-09-25channel-record: Use correct nick name for propertyPavel Grunt1-2/+2
2015-09-23Add glib-compat.c to POTFILES.inJonathon Jongsma1-0/+1
Some translatable strings were added in commit 8c37a340.
2015-09-18Add "monitors config position" capability.sstuts1-0/+2
This will allow Windows guests to determine if the client supports a monitors_config message from a multi-monitor guest that is not multi-headed, i.e., that has one monitor per driver. It keeps commit:8b0cd321d5a4d08ccba5845c5f2206e6f8032c1d from breaking if an updated win-qxl driver is paired with an older client. This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1248189 --- Changed from v1: Removed a local commit that preceded this one. --- Changed from v2: Changed name to "monitors config position" ---
2015-09-15build-sys: Fix spice-protocol requirements in .pc fileChristophe Fergeau1-1/+1
Commit d0ae58a8 added spice-protocol >= 0.12.10 to the Requires.private field in spice-client-glib.pc. However it's already present in the Requires field without a version check. Once spice-gtk is built and installed, building a program against spice-gtk needs spice-protocol, but no specific version of it, so we can drop the duplicate Requires.private requirement, and keep the unversioned one in Requires.
2015-09-10Don't send monitors config when Display widget is createdJonathon Jongsma1-14/+24
When a display channel is associated with a particular SpiceDisplay widget, it previously set the display to 'enabled' unconditionally. There is a couple of problems with this behavior. First, simply because a display widget has an associated display channel, it doesn't necessarily mean that the display is enabled. On linux guests, for instance, a display channel can have up to 4 displays for one channel, and perhaps only one of them is enabled. So, we shouldn't set the display to 'enabled' until we actually receive a monitors configuration message indicating that this display is enabled. The second problem is that this was triggering the client to send down a new monitors-config message to the server. This message is completely unnecessary since it is triggered by a message from the server. We should only be sending down new monitor configurations in response to changes from the client, not from the server.
2015-09-10Add spice_main_update_display_enabled()Jonathon Jongsma5-8/+36
This is a new function that allows the caller to decide whether to send the new status down to the server or not (analogous to the difference between spice_main_set_display() vs spice_man_update_display()). This new function is needed to reduce unnecessary MonitorsConfig messages from being sent to the server. Because spice-gtk does not maintain any display state internally, it depends on the application to maintain that state. Some state changes come from the server itself (e.g. the guest has changed resolution due to some activity within the guest), and some come from the application (e.g. the user has resized the window of the client). Changes that come from server updates do not need to be sent back down to the server, whereas those that originate from the application *do* need to be sent to the server.
2015-09-09file-xfer: Simplify time handlingPavel Grunt1-17/+9
Use g_get_monotonic_time() instead of g_date_time_new_now_local(). g_get_monotonic_time doesn't suffer discontinuities and it is sufficient for our purposes. There is no need for the complexity of GDateTime.
2015-09-08audio: Do not volume-sync without audioVictor Toso2-2/+8
In case audio backend is not initialized correctly or there isn't audio in the VM, we should not try to volume-sync. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1257210
2015-08-25file-xfer: Add debug messages about a file transfer progressPavel Grunt1-0/+46
During the file transfer debug messages about the progress are printed every 20 seconds for each of the file transfer tasks. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1140512 Acked-by: Frediano Ziglio <fziglio@redhat.com>
2015-08-25glib-compat: Add g_format_sizePavel Grunt2-0/+65
g_format_size_for_display is deprecated since glib 2.30. See glib commit afd1e3697065c1bd23fe9a1cacf43d8744d0bc9b g_format_size will be used in the following commit Acked-by: Frediano Ziglio <fziglio@redhat.com>
2015-08-21session: update spice_session_connect() docMarc-André Lureau1-1/+5
Update the documentation about the return value, and how to watch for connection success. Releated to: https://bugzilla.redhat.com/show_bug.cgi?id=1253848
2015-08-14Adjust to new SpiceImageCompress nameChristophe Fergeau3-29/+29
This has been renamed to SpiceImageCompression in order to avoid clashes with older spice-server in the SPICE_IMAGE_COMPRESS_ namespace. This commit is a straight rename of SpiceImageCompress to SpiceImageCompression and SPICE_IMAGE_COMPRESS_ to SPICE_IMAGE_COMPRESSION_
2015-08-14build-sys: Remove spice-protocol submoduleChristophe Fergeau2-3/+5
It's seeing regular releases and is API stable, so we don't need to bundle it with spice-gtk
2015-08-05usbredir: Add a few debug logsChristophe Fergeau2-3/+14
Currently, spice-gtk debugging logs contain no traces of the values of the auto-redir/redir-on-connect filter, and it does not tell you about the vid/pid of the devices being connected/redirected. This commit adds the appropriate SPICE_DEBUG/CHANNEL_DEBUG calls so that this data is logged.
2015-08-05channel: Don't warn when no CA is setChristophe Fergeau1-1/+0
Since v0.22~19 "Use system-wide trust certificate store", when neither SpiceSession::ca-file nor SpiceSession::ca are set, the system-wide CA store will be used to validate the SPICE certificates. However, there is still a g_warn_if_fail() checking that either ca or ca-file are set, which causes a runtime warning when trying to use the system-wide store. This commit removes it.
2015-08-03Notify about existence of monitor for all display channelsPavel Grunt1-4/+2
Windows guest can have disabled display on the display chanel #0, in that case it will not be listed in virt-viewer's "View->Displays" menu Resolves: https://bugs.freedesktop.org/show_bug.cgi?id=91489
2015-07-28Handle single headed monitors that have a non-zero x, y configSandy Stutsman1-1/+6
Each monitor on a Windows guest is represented as a separate, single-headed device with its own framebuffer. When there are multiple monitors, all monitors but one will have a non-zero xy config position. But even in these cases the whole area (frame-buffer) of each monitor should be updated. Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1202419
2015-07-28Add the gtk libraries to the gtk-scandoc link line.Jeremy White1-1/+1
This prevents a compile error on Debian Jessie, when building from git. This is fairly subtle, and Debian specific. It only happens when you use autoreconf to generate a new libtool script. Debian patches that script to require an explicit setting to link with all dependent libraries. It should be harmless on other distros, and it does save us Debian guys some hassle.
2015-07-13Use g_return_val_if_fail instead of wrong g_return_if_failPavel Grunt1-1/+1
The commit 4b5e6ec2114e1250c81027ebeac9cfe8d059153f introduced a function returning gboolean, g_return_val_if_fail() should be used instead of g_return_if_fail().
2015-07-13Send monitor config if at least one monitor has dimensionsPavel Grunt1-0/+21
If a client (virt-manager, spicy) is not setting display dimensions and the "resize-guest" property is disabled, spice-gtk sends a wrong monitor config message where all the monitors have width = heigh = 0 when the agent connects. This message can confuse the guest, in that case the guest will change the resolution of its monitor. Regression since 28312b8d1e287a320851e8828825f2ca138d8b0b Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1240721
2015-07-10This adds reference counting to cached images.Sandy Stutsman2-15/+47
Windows guests with multi-monitors will often send down the same image via different channels. If these instances are not counted, one channel can delete an image before all the rest of the channels are finished with it. In this case, the client will hang. This can happen, for instance, when the Windows guest is updating the monitor's wallpaper. There is a driver instance for each monitor, so each one is sending down its own copy of the same image with the same id. As one channel may be busier than another, the order that the client executes commands may not be the same order as the server issued them. Here's what can happen: On the server side: Monitor 1 sends image A Monitor 1 sends multiple rendering commands for image A Monitor 1 removes image A Monitor 2 sends image A Monitor 2 sends rendering commands for image A On the client side: Monitor 1 adds image A to the cache Monitor 1 starts rendering with image A Monitor 2 adds image A to the cache - has same id, so image is replaced Monitor 1 removes image A - image A is completely removed from cache Monitor 2 render command hangs waiting for image A Addresses bug: https://bugzilla.redhat.com/show_bug.cgi?id=1194354
2015-07-06Update spice-protocolChristophe Fergeau1-0/+0
This will fix EL6 builds. Christophe Fergeau (1): m4: Add compat AS_VAR_APPEND for older autoconf Lukas Venhoda (3): ppc: Fix quic decode endianess ppc: Fix lz magic endianess ppc: Fix quic magic endianess
2015-06-30Make monitors config debug output more clearJonathon Jongsma2-2/+3
Indicate whether the monitors config debug output is from sending or receiving new monitors configuration. You can tell this by looking at which channel is involved (main vs display), but making it more explicit is helpful for glancing through logs.
2015-06-29Display: Send a preferred compression message on init.Javier Celaya1-0/+11
If the user prefers a specific compression algorithm, report it when setting up the display channel.
2015-06-29Add a preferred-compression program optionJavier Celaya1-0/+37
2015-06-29Spice-session: Add preferred-compression property.Javier Celaya2-0/+58
Also, depend on the spice-common commit that introduces the SpiceImageCompress enum.
2015-06-26build-sys: Fix build with automake < 1.13Christophe Fergeau1-1/+2
AC_CONFIG_MACRO_DIRS is not available with older automake versions, which causes autogen.sh failures on RHEL6. m4_include() can be used instead.
2015-06-25Send monitor config if guest supports sparse monitorsPavel Grunt1-8/+9
It is ok to send monitor configuration even for displays which are not disabled or enabled. Because the guest having support for the sparse monitor configuration (VD_AGENT_CAP_SPARSE_MONITORS_CONFIG) will not resize the monitor which is disabled / undefined. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=90914
2015-06-25channel-main: Use enum to describe display statePavel Grunt1-10/+14
2015-06-22build-sys: Use SPICE_CHECK_LZ4Christophe Fergeau2-12/+1
spice-common now has an m4 macro adding a --enable-lz4 option and doing the needed checks, so we can use it in configure.ac rather than duplicating it here.
2015-06-22build-sys: Use SPICE_CHECK_SMARTCARDChristophe Fergeau1-17/+2
spice-common has an m4 macro adding a --enable-smartcard option and doing the needed checks, so we can use it in configure.ac rather than duplicating it here.
2015-06-19spicy-*: Remove translation supportChristophe Fergeau5-83/+64
These are only meant to be test tools so they don't need to be translated.
2015-06-18spicy: Enable recent chooser on windowsLukas Venhoda2-10/+0
Recent chooser is working correctly in windows.
2015-06-18spicy: Replace duplicated code with a for loopLukas Venhoda1-11/+6
Changed piece of code working with fixed size array into a for loop.
2015-06-18spicy: Host and port (or tls) are now requiredLukas Venhoda1-5/+27
Connect button is now non-sensitive when host and port (or tls) entry is empty. Pressing enter will now also NOT connect, when the entries are empty.
2015-06-18spicy: Fixed reselecting in recent chooserLukas Venhoda1-0/+11
Selecting an entry in the recent connections list, and then modifying the host/port/TLS port, and double-clicking on that same entry in the list would cause spicy to connect to the edited address rather than the one which was picked in the recent chooser. After this commit, the selection will be cleared from the recent chooser, and double-clicking on an entry after editing it will always trigger a 'selection-changed' signal, which will properly set the address to connect to.
2015-06-18spicy: Changed the dialog into a windowLukas Venhoda3-38/+120
Changed connect dialog from GtkDialog to GtkWindow. Added the necessary signals and buttons, to keep then behaviour of a dialog (ESC to close, ENTER to submit). spicy_connect_dialog now returns TRUE and FALSE instead of 0 and -1.
2015-06-18spicy: Move connect dialog to its own fileLukas Venhoda5-125/+176
Connect dialog from spicy is now in its own file. Renamed connect_dialog to spicy_connect_dialog. Added new file for translation.
2015-06-18spice-widget: keypress-delay set by env varVictor Toso1-1/+9