Age | Commit message (Collapse) | Author | Files | Lines |
|
'sources' should be a NULL-terminated array, but the parameter
documentation treats it as if it is a single file object.
|
|
|
|
Since these messages are only used for terminal debug output, let's not
waste time translating them.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Some translatable strings were added in commit 8c37a340.
|
|
This will allow Windows guests to determine if the client supports a
monitors_config message from a multi-monitor guest that is not
multi-headed, i.e., that has one monitor per driver.
It keeps commit:8b0cd321d5a4d08ccba5845c5f2206e6f8032c1d
from breaking if an updated win-qxl driver is paired with an older client.
This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1248189
---
Changed from v1: Removed a local commit that preceded this one.
---
Changed from v2: Changed name to "monitors config position"
---
|
|
Commit d0ae58a8 added spice-protocol >= 0.12.10 to the Requires.private
field in spice-client-glib.pc. However it's already present in the
Requires field without a version check. Once spice-gtk is built and
installed, building a program against spice-gtk needs spice-protocol,
but no specific version of it, so we can drop the duplicate
Requires.private requirement, and keep the unversioned one in Requires.
|
|
When a display channel is associated with a particular SpiceDisplay
widget, it previously set the display to 'enabled' unconditionally.
There is a couple of problems with this behavior.
First, simply because a display widget has an associated display
channel, it doesn't necessarily mean that the display is enabled. On
linux guests, for instance, a display channel can have up to 4 displays
for one channel, and perhaps only one of them is enabled. So, we
shouldn't set the display to 'enabled' until we actually receive a
monitors configuration message indicating that this display is enabled.
The second problem is that this was triggering the client to send down a
new monitors-config message to the server. This message is completely
unnecessary since it is triggered by a message from the server. We
should only be sending down new monitor configurations in response to
changes from the client, not from the server.
|
|
This is a new function that allows the caller to decide whether to send
the new status down to the server or not (analogous to the difference
between spice_main_set_display() vs spice_man_update_display()).
This new function is needed to reduce unnecessary MonitorsConfig
messages from being sent to the server. Because spice-gtk does not
maintain any display state internally, it depends on the application to
maintain that state. Some state changes come from the server itself
(e.g. the guest has changed resolution due to some activity within the
guest), and some come from the application (e.g. the user has resized
the window of the client). Changes that come from server updates do not
need to be sent back down to the server, whereas those that originate
from the application *do* need to be sent to the server.
|
|
Use g_get_monotonic_time() instead of g_date_time_new_now_local().
g_get_monotonic_time doesn't suffer discontinuities and it is sufficient
for our purposes. There is no need for the complexity of GDateTime.
|
|
In case audio backend is not initialized correctly or there isn't audio
in the VM, we should not try to volume-sync.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1257210
|
|
During the file transfer debug messages about the progress are printed
every 20 seconds for each of the file transfer tasks.
Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1140512
Acked-by: Frediano Ziglio <fziglio@redhat.com>
|
|
g_format_size_for_display is deprecated since glib 2.30. See glib commit
afd1e3697065c1bd23fe9a1cacf43d8744d0bc9b
g_format_size will be used in the following commit
Acked-by: Frediano Ziglio <fziglio@redhat.com>
|
|
Update the documentation about the return value, and how to watch for
connection success.
Releated to:
https://bugzilla.redhat.com/show_bug.cgi?id=1253848
|
|
This has been renamed to SpiceImageCompression in order to avoid clashes
with older spice-server in the SPICE_IMAGE_COMPRESS_ namespace. This
commit is a straight rename of SpiceImageCompress to
SpiceImageCompression and SPICE_IMAGE_COMPRESS_ to
SPICE_IMAGE_COMPRESSION_
|
|
It's seeing regular releases and is API stable, so we don't need to
bundle it with spice-gtk
|
|
Currently, spice-gtk debugging logs contain no traces of the
values of the auto-redir/redir-on-connect filter, and it does not tell
you about the vid/pid of the devices being connected/redirected.
This commit adds the appropriate SPICE_DEBUG/CHANNEL_DEBUG calls so that
this data is logged.
|
|
Since v0.22~19 "Use system-wide trust certificate store", when neither
SpiceSession::ca-file nor SpiceSession::ca are set, the system-wide
CA store will be used to validate the SPICE certificates.
However, there is still a g_warn_if_fail() checking that either ca or
ca-file are set, which causes a runtime warning when trying to use the
system-wide store. This commit removes it.
|
|
Windows guest can have disabled display on the display chanel #0, in
that case it will not be listed in virt-viewer's "View->Displays" menu
Resolves:
https://bugs.freedesktop.org/show_bug.cgi?id=91489
|
|
Each monitor on a Windows guest is represented as a separate, single-headed
device with its own framebuffer. When there are multiple monitors, all
monitors but one will have a non-zero xy config position. But even in
these cases the whole area (frame-buffer) of each monitor should be
updated.
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1202419
|
|
This prevents a compile error on Debian Jessie, when building from git.
This is fairly subtle, and Debian specific. It only happens when you use
autoreconf to generate a new libtool script. Debian patches that script
to require an explicit setting to link with all dependent libraries.
It should be harmless on other distros, and it does save us Debian guys some
hassle.
|
|
The commit 4b5e6ec2114e1250c81027ebeac9cfe8d059153f introduced a function
returning gboolean, g_return_val_if_fail() should be used instead of
g_return_if_fail().
|
|
If a client (virt-manager, spicy) is not setting display dimensions
and the "resize-guest" property is disabled, spice-gtk sends a wrong
monitor config message where all the monitors have width = heigh = 0
when the agent connects. This message can confuse the guest, in that
case the guest will change the resolution of its monitor.
Regression since 28312b8d1e287a320851e8828825f2ca138d8b0b
Resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=1240721
|
|
Windows guests with multi-monitors will often send down the same image
via different channels. If these instances are not counted, one channel
can delete an image before all the rest of the channels are finished with
it. In this case, the client will hang.
This can happen, for instance, when the Windows guest is updating the
monitor's wallpaper. There is a driver instance for each monitor, so each
one is sending down its own copy of the same image with the same id. As
one channel may be busier than another, the order that the client executes
commands may not be the same order as the server issued them. Here's what
can happen:
On the server side:
Monitor 1 sends image A
Monitor 1 sends multiple rendering commands for image A
Monitor 1 removes image A
Monitor 2 sends image A
Monitor 2 sends rendering commands for image A
On the client side:
Monitor 1 adds image A to the cache
Monitor 1 starts rendering with image A
Monitor 2 adds image A to the cache - has same id, so image is replaced
Monitor 1 removes image A - image A is completely removed from cache
Monitor 2 render command hangs waiting for image A
Addresses bug: https://bugzilla.redhat.com/show_bug.cgi?id=1194354
|
|
This will fix EL6 builds.
Christophe Fergeau (1):
m4: Add compat AS_VAR_APPEND for older autoconf
Lukas Venhoda (3):
ppc: Fix quic decode endianess
ppc: Fix lz magic endianess
ppc: Fix quic magic endianess
|
|
Indicate whether the monitors config debug output is from sending or
receiving new monitors configuration. You can tell this by looking at
which channel is involved (main vs display), but making it more explicit
is helpful for glancing through logs.
|
|
If the user prefers a specific compression algorithm, report it when
setting up the display channel.
|
|
|
|
Also, depend on the spice-common commit that introduces the
SpiceImageCompress enum.
|
|
AC_CONFIG_MACRO_DIRS is not available with older automake versions,
which causes autogen.sh failures on RHEL6. m4_include() can be used
instead.
|
|
It is ok to send monitor configuration even for displays which are not
disabled or enabled. Because the guest having support for the sparse
monitor configuration (VD_AGENT_CAP_SPARSE_MONITORS_CONFIG) will not
resize the monitor which is disabled / undefined.
Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=90914
|
|
|
|
spice-common now has an m4 macro adding a --enable-lz4 option and
doing the needed checks, so we can use it in configure.ac rather than
duplicating it here.
|
|
spice-common has an m4 macro adding a --enable-smartcard option and
doing the needed checks, so we can use it in configure.ac rather than
duplicating it here.
|
|
These are only meant to be test tools so they don't need to be
translated.
|
|
Recent chooser is working correctly in windows.
|
|
Changed piece of code working with fixed size array into a for loop.
|
|
Connect button is now non-sensitive when host and port (or tls) entry is empty.
Pressing enter will now also NOT connect, when the entries are empty.
|
|
Selecting an entry in the recent connections list, and then modifying
the host/port/TLS port, and double-clicking on that same entry in the
list would cause spicy to connect to the edited address rather than
the one which was picked in the recent chooser.
After this commit, the selection will be cleared from the recent
chooser, and double-clicking on an entry after editing it will always
trigger a 'selection-changed' signal, which will properly set the
address to connect to.
|
|
Changed connect dialog from GtkDialog to GtkWindow.
Added the necessary signals and buttons, to keep then
behaviour of a dialog (ESC to close, ENTER to submit).
spicy_connect_dialog now returns TRUE and FALSE instead of 0 and -1.
|
|
Connect dialog from spicy is now in its own file.
Renamed connect_dialog to spicy_connect_dialog.
Added new file for translation.
|
|
|