summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarc-André Lureau <marcandre.lureau@redhat.com>2015-05-06 17:56:49 +0200
committerMarc-André Lureau <marcandre.lureau@redhat.com>2015-05-07 21:50:43 +0200
commit05c6088d1dacef8a48554d4954c40f6612adb35c (patch)
tree0f8ed44a3b67edd768b5bd6b864c0d00af71f153
parent9546b571d7143e4c9efcb022d6016ea1c9ed2536 (diff)
webdav: check g_output_stream_write_all() return value
Check g_output_stream_write_all() return value to silence a coverity CHECKED_RETURN warning
-rw-r--r--gtk/channel-webdav.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/gtk/channel-webdav.c b/gtk/channel-webdav.c
index 95c0521..1d3862e 100644
--- a/gtk/channel-webdav.c
+++ b/gtk/channel-webdav.c
@@ -147,8 +147,7 @@ static gboolean output_queue_idle(gpointer user_data)
return FALSE;
}
- g_output_stream_write_all(q->output, e->buf, e->size, NULL, NULL, &error);
- if (error)
+ if (!g_output_stream_write_all(q->output, e->buf, e->size, NULL, NULL, &error))
goto err;
else if (e->pushed_cb)
e->pushed_cb(q, e->user_data);
@@ -159,7 +158,9 @@ static gboolean output_queue_idle(gpointer user_data)
return TRUE;
err:
- g_warning("error: %s", error->message);
+ g_warning("failed to write to output stream");
+ if (error)
+ g_warning("error: %s", error->message);
g_clear_error(&error);
q->idle_id = 0;