summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Stellard <thomas.stellard@amd.com>2013-06-26 18:21:22 +0000
committerTom Stellard <thomas.stellard@amd.com>2013-06-26 18:21:22 +0000
commita6c4ea315053dc20ced08f9e0f9efb545e2179b7 (patch)
tree6985c0da92b622b6fa1317bd7889d5b885df30ab
parent160ef139d86fe26f383518a1ef84b9a216cf207e (diff)
Add a TODO note.
Patch by: Aaron Watry git-svn-id: https://llvm.org/svn/llvm-project/libclc/trunk@184998 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--generic/lib/integer/rotate.inc4
1 files changed, 4 insertions, 0 deletions
diff --git a/generic/lib/integer/rotate.inc b/generic/lib/integer/rotate.inc
index 7792a97..b34ffed 100644
--- a/generic/lib/integer/rotate.inc
+++ b/generic/lib/integer/rotate.inc
@@ -21,6 +21,10 @@ _CLC_OVERLOAD _CLC_DEF GENTYPE rotate(GENTYPE x, GENTYPE n){
return ( (((UGENTYPE)x) >> -n) | (x << (GENSIZE + n)) );
}
#else
+ //XXX: There's a lot of __builtin_astype calls to cast everything to
+ // unsigned ... This should be improved so that if GENTYPE==UGENTYPE, no
+ // casts are required.
+
UGENTYPE x_1 = __builtin_astype(x, UGENTYPE);
UGENTYPE amt;