diff options
| author | Sreerenj Balachandran <sreerenj.balachandran@intel.com> | 2016-02-29 12:35:58 +0200 |
|---|---|---|
| committer | Sreerenj Balachandran <sreerenj.balachandran@intel.com> | 2016-02-29 12:35:58 +0200 |
| commit | cf7056a312e959643092ed31a0d8cfdffab6a8c6 (patch) | |
| tree | c546a4cb2d1d0b7abae2dc7570e833bbdf46bda4 | |
| parent | 019bc678371978bae0c1cfa2ac6de8d0a4f3ab54 (diff) | |
videoparsers: h264: Disable passthorugh mode enabling
Enabling passthorugh mode is causing multiple issue:
For nal aligned multiresoluton streams, passthrough mode
make h264parse unable to advertise the new resoultions.
Also causing issues while parsing MVC streams which have two
separate layers (base-view and non-base-view).
This fix is only a temporary workaround.
For MVC, proper fixes needed in many places:
(handle prefix nal unit, handle non-base-view slice nal extension,
fix the picture_start detection for multi-layer-mvc streams etc)
https://bugzilla.gnome.org/show_bug.cgi?id=758656
| -rw-r--r-- | gst/videoparsers/gsth264parse.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/gst/videoparsers/gsth264parse.c b/gst/videoparsers/gsth264parse.c index 6721657c2..8907eb41d 100644 --- a/gst/videoparsers/gsth264parse.c +++ b/gst/videoparsers/gsth264parse.c @@ -2368,6 +2368,12 @@ gst_h264_parse_pre_push_frame (GstBaseParse * parse, GstBaseParseFrame * frame) } } + /* Fixme: setting passthrough mode casuing multiple issues: + * For nal aligned multiresoluton streams, passthrough mode make h264parse + * unable to advertise the new resoultions. Also causing issues while + * parsing MVC streams when it has two layers. + * Disabing passthourgh mode for now */ +#if 0 /* If SPS/PPS and a keyframe have been parsed, and we're not converting, * we might switch to passthrough mode now on the basis that we've seen * the SEI packets and know optional caps params (such as multiview). @@ -2379,6 +2385,7 @@ gst_h264_parse_pre_push_frame (GstBaseParse * parse, GstBaseParseFrame * frame) gst_base_parse_set_passthrough (parse, TRUE); } } +#endif gst_h264_parse_reset_frame (h264parse); |