| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
Set SPICE_PROXY environment variable accordingly.
|
|
Quoting GLib:
Environment variable handling in UNIX is not thread-safe, and your
program may crash if one thread calls g_setenv() while another thread
is calling getenv(). (And note that many functions, such as gettext(),
call getenv() internally.) This function is only safe to use at the
very start of your program, before creating any other threads (or
creating objects that create worker threads of their own).
If you need to set up the environment for a child process, you can use
g_get_environ() to get an environment array, modify that with
g_environ_setenv() and g_environ_unsetenv(), and then pass that array
directly to execvpe(), g_spawn_async(), or the like.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Adding some more channels to the RHEL 5 list. The longer winded story is
that ovirt-engine passes us those values because vdsm unconditionally
removes the first letter of every channel name in the secure channels
list (aka SSLChannels here). Instead of changing vdsm, and dealing with
multiple vdsm versions for each cluster, a huge PITA, let spice-xpi
parse some extra channel names.
RHBZ: 790416
|
|
|
|
|
|
Use %z modifier for ssize_t variables, and for an uint32_t variable,
the %l modifier shouldn't be neeeded.
|
|
|
|
All callers were using std::string::c_str(), better to move this
call to SendStr instead of doing it everywhere.
|
|
The secure channel names need to be fixed for compatibility with
older spice versions. However, it's better to do it directly when
m_secure_channels is set rather than waiting until its first use
|
|
The Firefox plugin exposes the UsbAutoShare property and the SetUsbFilter
method that were not wired until now. This commit propagates their value to
the nsPluginInstance object and send them through the controller socket.
|
|
|
|
|
|
|
|
|
|
- ColorDepth should be 32 or 16
- DisableEffects is a comma separated string, composed of one or more of
the following options: "wallpaper"/"font-smooth"/"animation", or "all"
rhbz #747313
Signed-off-by: Yonit Halperin <yhalperi@redhat.com>
|
|
|
|
Don't attempt to create an unused directory
See also: https://bugzilla.redhat.com/show_bug.cgi?id=801871
|
|
|
|
gcc complains about the format string being wrong otherwise (the
modifier to use is compiler/architecture dependant).
|
|
It was spelt SendCtrlAltdelete (lower case "d" in delete) throughout
the code base while spice-x and the rhev/ovirt portals use
SendCtrlAltDelete. This commit changes all occurences of Altdelete
to AltDelete. After this change, the "Pass Ctrl+Alt+Del" check box in
the rhev/ovirt portal works as expected.
|
|
On Linux, the default behaviour of the client is to have
Ctrl+Alt+Del passthrough enabled, so it's better to default to
enabling it from the controller as well to avoid getting a different
behaviour when the client handles controller messages about CAD.
Thanks to Uri for this suggestion.
|
|
|
|
|
|
::SendVal will not send messages when the value is 0, which is not
what is expected when sending a boolean value.
|
|
Interestingly, this doesn't seem to prevent it from working
correctly. So this patch is mostly for correctness.
|
|
|
|
GLib is used in the defacto library for desktop projects. It includes
logging facilities that can be filtered by domain and level, and can
be redirected or formated in various ways. Instead of pulling an extra
large depedency for a small plugin, let's use what is common to the
desktop.
Afaict, nobody else is using log4cpp in Fedora. The configuration file
is not user friendly. In comparison, you can just run
"G_MESSAGES_DEBUG=SpiceXPI firefox" and easily modify logging via
environment variable. There is no logging to file, and there is no
configuration file. If you want to redirect to file, you can do so via
redirection, or other mechanisms (ldpreload, environment..).
|
|
- remove invalid or obsolete includes, variables
- get rid of useless variables
- make it more silent
- shorten file location: /foo/baz/bar -> bar
- prefer $(top_srcdir)/foo/bar vs ../../../foo/bar
- remove useless configure check
- sort a few lines
|
|
When the child exits quickly (failed to start etc..), it doesn't get
tracked properly and when receiving sigchld, "fake_this" may be NULL
leading to a crash (fake_this = s_children[info->si_pid])
|
|
|
|
|
|
|
|
Spice XPI assumes that the client is the child PID, however for
debugging reasons, it's useful to spawn the client as a sub process
of the launched program. This allows clients such as:
#!/bin/sh
exec gnome-terminal -e "gdb --args spicec --controller $@"
|
|
Deal with const and non-const return value of NPP_GetMIMEDescription().
Although it is hard to find evidences of how this value is used, I
think the non-const value could return a static string. But I prefer
being on the safe side and return a strdup() to the risk of leaking
that string on older versions.
Fixes the build on RHEL6 with xulrunner-1.9.2.24-2.el6.
|
|
Fix out of tree build, and some minor clean-up.
|
|
|
|
|
|
|
|
|
|
|
|
Although not really important, the previous code was racy (stat + exec).
I propose running /usr/libexec/spice-xpi-client without parameters,
which could be a shell script with the required arguments to call
spicec or other spice clients (and could be easily tweaked to run
various clients depending on environment etc..)
Ex:
exec spicec --controller "$@"
|
|
|
|
|
