Fix task could be used uninitialized

1 files changed, 10 insertions, 6 deletions

diff --git a/vdagent/file_xfer.cpp b/vdagent/file_xfer.cpp
index 6ba15a3..9d2f3c5 100644
--- a/vdagent/file_xfer.cpp
+++ b/vdagent/file_xfer.cpp
@@ -82,7 +82,7 @@ bool FileXfer::handle_data(VDAgentFileXferDataMessage* data,
                            VDAgentFileXferStatusMessage* status)
 {
     FileXferTasks::iterator iter;
-    FileXferTask* task;
+    FileXferTask* task = NULL;
     DWORD written;
 
     status->id = data->id;
@@ -108,13 +108,17 @@ bool FileXfer::handle_data(VDAgentFileXferDataMessage* data,
     }
     vd_printf("%u completed", iter->first);
     status->result = VD_AGENT_FILE_XFER_STATUS_SUCCESS;
+
 fin:
-    CloseHandle(task->handle);
-    if (status->result != VD_AGENT_FILE_XFER_STATUS_SUCCESS) {
-        DeleteFileA(task->name);
+    if (task) {
+        CloseHandle(task->handle);
+        if (status->result != VD_AGENT_FILE_XFER_STATUS_SUCCESS) {
+            DeleteFileA(task->name);
+        }
+        _tasks.erase(iter);
+        delete task;
     }
-    _tasks.erase(iter);
-    delete task;
+
     return true;
 }