diff options
| author | Zeeshan Ali (Khattak) <zeeshanak@gnome.org> | 2013-01-31 15:53:52 +0100 |
|---|---|---|
| committer | Zeeshan Ali (Khattak) <zeeshanak@gnome.org> | 2013-02-07 01:56:29 +0200 |
| commit | 8e770e62e81a888ba29d6feb36ad17b85fcdd8e1 (patch) | |
| tree | ddbef5b498eb45624494af832a130080b39b9632 | |
| parent | 03e95491b2ab4cc538f06d1d6f5c3053331ddb5f (diff) | |
install-script tool: Take GFile creation out of the loop
Also, unref the GFile when done.
| -rw-r--r-- | tools/osinfo-install-script.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/tools/osinfo-install-script.c b/tools/osinfo-install-script.c index fabce96..ac71cc0 100644 --- a/tools/osinfo-install-script.c +++ b/tools/osinfo-install-script.c @@ -190,6 +190,7 @@ static gboolean generate_script(OsinfoOs *os) OsinfoInstallScriptList *scripts = osinfo_os_get_install_script_list(os); OsinfoInstallScriptList *profile_scripts; OsinfoFilter *filter; + GFile *dir; GList *l, *tmp; gboolean ret = FALSE; GError *error = NULL; @@ -209,10 +210,10 @@ static gboolean generate_script(OsinfoOs *os) goto cleanup; } + dir = g_file_new_for_commandline_arg(output_dir ? output_dir : "."); + for (tmp = l; tmp != NULL; tmp = tmp->next) { OsinfoInstallScript *script = tmp->data; - GFile *dir = g_file_new_for_commandline_arg(output_dir ? - output_dir : "."); if (prefix) osinfo_install_script_set_output_prefix(script, prefix); @@ -236,6 +237,7 @@ static gboolean generate_script(OsinfoOs *os) g_object_unref(scripts); g_object_unref(filter); g_object_unref(profile_scripts); + g_object_unref(dir); return ret; } |