Age | Commit message (Collapse) | Author | Files | Lines |
|
When using g_variant_builder_new(), we must call
g_variant_builder_unref() to free it:
"You should call g_variant_builder_unref() on the return value when it
is no longer needed. The memory will not be automatically freed by any
other call.
In most cases it is easier to place a GVariantBuilder directly on the
stack of the calling function and initialise it with
g_variant_builder_init()."
One of these leaks showed up in valgrind as:
==20702== 16,416 bytes in 114 blocks are definitely lost in loss record 2,114 of 2,115
==20702== at 0x4A0645D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==20702== by 0x56EDDF2: g_malloc (gmem.c:97)
==20702== by 0x570691C: g_slice_alloc (gslice.c:1007)
==20702== by 0x5729743: g_variant_builder_new (gvariant.c:3169)
==20702== by 0x40297B: ibus_config_dconf_get_values (config.c:413)
==20702== by 0x4E44FF2: ibus_config_service_service_method_call (ibusconfigservice.c:214)
==20702== by 0x4E33249: ibus_service_service_method_call_cb (ibusservice.c:395)
==20702== by 0x51880D8: call_in_idle_cb (gdbusconnection.c:4875)
==20702== by 0x56E81D7: g_idle_dispatch (gmain.c:5319)
==20702== by 0x56E58F1: g_main_dispatch (gmain.c:3064)
==20702== by 0x56E6667: g_main_context_dispatch (gmain.c:3663)
==20702== by 0x56E6859: g_main_context_iterate (gmain.c:3734)
|
|
This is an amendment to 6ca5ddb3. As content-type (input-purpose and hints)
can change after focus-in, we should monitor the changes.
BUG=
R=takao.fujiwara1@gmail.com
Review URL: https://codereview.appspot.com/83920043
|
|
gnome-shell gets input purpose so that disables IME with password mode.
Review URL: https://codereview.appspot.com/81770044
|
|
GDBusProxy updates the cache immediatelly with the first call only
and has to save the next call in the cache by manual.
BUG=RH#1013948
TEST=password on gnome-shell 3.10.
Review URL: https://codereview.appspot.com/14196043
|
|
BUG=http://code.google.com/p/ibus/issues/detail?id=1660
TEST=make install
Review URL: https://codereview.appspot.com/14119043
|
|
BUG=http://code.google.com/p/ibus/issues/detail?id=1568
TEST=Disable global engine with ibus-setup.
Review URL: https://codereview.appspot.com/12957046
|
|
Add a new D-Bus method SetContentType to InputContext and Engine, to
notify engines of the content-type (primary purpose and hints) of
input context. This is useful to implement intelligent features in
engines, such as automatic input-mode switch and text prediction.
The "purpose" and "hints" arguments are compatible with
GtkInputPurpose and GtkInputHints:
https://developer.gnome.org/gtk3/unstable/GtkEntry.html#GtkInputPurpose
https://developer.gnome.org/gtk3/unstable/GtkEntry.html#GtkInputHints
and the API is similar to the content_type event in the Wayland Input
Method Framework:
http://cgit.freedesktop.org/wayland/weston/tree/protocol/input-method.xml#n202
BUG=
Review URL: https://codereview.appspot.com/11422043
|
|
BUG=http://code.google.com/p/ibus/issues/detail?id=1424
TEST=rpmlint
Review URL: https://codereview.appspot.com/12526043
|
|
This fixes a few problems of PropertiesChanged signal emission.
First, it should be sent only when the properties have changed.
Second, invalidated_properties should be set when the properties have
been reset, not on error. Finally, the sender should be
"org.freedesktop.IBus" rather than "org.freedesktop.DBus".
BUG=
R=takao.fujiwara1@gmail.com
Review URL: https://codereview.appspot.com/11465045
|
|
BUG=http://code.google.com/p/ibus/issues/detail?id=1636
TEST=src/tests/ibus-bus.c
Review URL: https://codereview.appspot.com/11004043
Patch from Eduardo Lima (Etrunko) <eduardo.lima@intel.com>.
|
|
BUG=http://code.google.com/p/ibus/issues/detail?id=1638
TEST=bus/ibusimpl.c
Review URL: https://codereview.appspot.com/11471044
Patch from Osamu Aoki <osamu@debian.org>.
|
|
BUG=http://code.google.com/p/ibus/issues/detail?id=1637
TEST=bus/test-client.c
Review URL: https://codereview.appspot.com/11336044
|
|
gnome-settings-daemon runs ibus-daemon after the user configures
any input method engines and causes a delay to show the engines
on UI because no cache exists for ibus-daemon.
The system cache can avoid the user timing.
Review URL: https://codereview.appspot.com/10364043
|
|
Review URL: https://codereview.appspot.com/9477043
|
|
The make variable INCLUDES is now obsoleted by AM_CPPFLAGS.
BUG=
R=Shawn.P.Huang@gmail.com
Review URL: https://codereview.appspot.com/9915054
|
|
https://git.gnome.org/browse/glib/commit/?id=1dc774a653e992e1153fbed16f90097fa8db467f
https://git.gnome.org/browse/vala/commit/?id=f1fbafdfdc91fadaa57d2e073fc29cc6804d6ae3
Review URL: https://codereview.appspot.com/9727047
|
|
This is not an actual application, it just starts the daemon in the
background. That's not something that should be in the application
list. It should be started in the background when necessary.
BUG=http://code.google.com/p/ibus/issues/detail?id=1628
Review URL: https://codereview.appspot.com/9833043
Patch from Colin Walters <walters@verbum.org>.
|
|
Review URL: https://codereview.appspot.com/9413043
|
|
BUG=http://code.google.com/p/ibus/issues/detail?id=1606
Review URL: https://codereview.appspot.com/8112044
|
|
BUG=None
TEST=Manual
Review URL: https://codereview.appspot.com/7531047
|
|
Currently the first ibus engine only is running but the second engine
is also frequently used. It is good to run the second engine before
user types Ctrl+space.
BUG=RH#838734
TEST=src/tests/ibus-bus
Review URL: https://codereview.appspot.com/7433049
|
|
Recent dbus-monitor supplies "eavesdrop" match rule which ibus-daemon
does not accept. This patch silently ignores the rule so ibus-daemon
behave the same as before.
BUG=none
Review URL: https://codereview.appspot.com/7225062
|
|
BUG=None
Review URL: https://codereview.appspot.com/6775097
|
|
BUG=Issue#1514
Review URL: https://codereview.appspot.com/6589065
|
|
Don't load components from /usr/share/ibus/components if
IBUS_COMPONENT_PATH is set. Currently the envvar is only useful
for testing and appending the standard path makes little sense.
BUG=none
Review URL: https://codereview.appspot.com/6753044
|
|
TEST=Manually
Review URL: https://codereview.appspot.com/6651061
|
|
TEST=Manually
Review URL: https://codereview.appspot.com/6499112
|
|
BUG=none
Review URL: https://codereview.appspot.com/6506094
|
|
Previously ibus-daemon did not make fake_context focused when focus-out, while it is supposed to do.
BUG=none
Review URL: https://codereview.appspot.com/6492086
|
|
Moved engine specific test from ibus-bus.c to a separate
file, so that it can be conditionally built depending on
--enable-engine.
Also do not register duplicate engine when loading component files.
This is for the case when two engine descs with the
same name are in different directories in IBUS_COMPONENT_PATH.
BUG=none
Review URL: https://codereview.appspot.com/6480052
|
|
BUG=none
Review URL: https://codereview.appspot.com/6455068
|
|
This makes it easier for third parties to track the ibus-daemon life
cycle.
BUG=http://code.google.com/p/ibus/issues/detail?id=1476
TEST=
Review URL: https://codereview.appspot.com/6374058
Patch from Rui Matos <tiagomatos@gmail.com>.
|
|
BUG=http://code.google.com/p/ibus/issues/detail?id=1438
TEST=Linux desktop
Review URL: https://codereview.appspot.com/6121053
|
|
BUG=none
TEST=manual
Review URL: https://codereview.appspot.com/5824046
|
|
BUG=None
TEST=Make
Review URL: https://codereview.appspot.com/5756061
|
|
TEST=Linux desktop
Review URL: https://codereview.appspot.com/5730046
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|