diff options
author | Peter Meerwald-Stadler <pmeerw@pmeerw.net> | 2017-03-01 20:37:06 +0100 |
---|---|---|
committer | Peter Meerwald-Stadler <pmeerw@pmeerw.net> | 2017-03-07 09:47:46 +0100 |
commit | 0cb72beaceca1e8e8e3eb330cbaa516912fa6dbd (patch) | |
tree | 3ba7932dd51dee47c453f62f16c07ce0b83c4511 | |
parent | 233cb4516a6d78cd65beef80ec6b46cd1f6c1aed (diff) |
raop: Fix potential NULL dereference
'realm' is mandatory
Signed-off-by: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
-rw-r--r-- | src/modules/raop/raop-client.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/modules/raop/raop-client.c b/src/modules/raop/raop-client.c index 9181e81b..1bd4c4a0 100644 --- a/src/modules/raop/raop-client.c +++ b/src/modules/raop/raop-client.c @@ -1259,13 +1259,13 @@ static void rtsp_auth_cb(pa_rtsp_client *rtsp, pa_rtsp_state_t state, pa_rtsp_st pa_xfree(token); } - if (pa_safe_streq(mth, "Basic")) { + if (pa_safe_streq(mth, "Basic") && realm) { rtrim_char(realm, '\"'); pa_raop_basic_response(DEFAULT_USER_NAME, c->password, &response); ath = pa_sprintf_malloc("Basic %s", response); - } else if (pa_safe_streq(mth, "Digest")) { + } else if (pa_safe_streq(mth, "Digest") && realm && nonce) { rtrim_char(realm, '\"'); rtrim_char(nonce, '\"'); |