summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Stone <daniels@collabora.com>2018-03-07 12:41:12 +0000
committerDaniel Stone <daniels@collabora.com>2018-03-07 17:19:29 +0000
commit45eee3fd44f4fa253cd4d5c03f48d4a6899f899f (patch)
tree54f631ac78482067f97c5c7cbc107791b7b6bd40
parent7b12381723021fd5fbcf761e6832dd16a14f52d4 (diff)
drm/atomic: Refuse to add invalid objects to requests
Object and property IDs cannot be zero. Prevent them from being added to the request stream at all, rather than breaking at commit time. Signed-off-by: Daniel Stone <daniels@collabora.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-rw-r--r--xf86drmMode.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/xf86drmMode.c b/xf86drmMode.c
index 15957ffc..bd59ef25 100644
--- a/xf86drmMode.c
+++ b/xf86drmMode.c
@@ -1313,6 +1313,9 @@ int drmModeAtomicAddProperty(drmModeAtomicReqPtr req,
if (!req)
return -EINVAL;
+ if (object_id == 0 || property_id == 0)
+ return -EINVAL;
+
if (req->cursor >= req->size_items) {
drmModeAtomicReqItemPtr new;