diff options
author | Deepika Aggarwal <deepika.a@samsung.com> | 2015-12-03 11:22:56 +0530 |
---|---|---|
committer | Simon McVittie <simon.mcvittie@collabora.co.uk> | 2016-07-01 16:46:04 +0100 |
commit | b36708830b8a0e5c1166a882cba5bbe7afa966ca (patch) | |
tree | 9e4f9a45031deb1ff0395c5b840dd4e1ad2b3f24 | |
parent | 187ae737ec3319383cfe5e6282d1c7e0b9550dcc (diff) |
Be explicit about enum comparison in bus_config_load()
XML_Parse() can potentially return values other than OK (1) or ERROR (0),
and they aren't errors.
Signed-off-by: Deepika Aggarwal <deepika.a@samsung.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=93205
[smcv: improve commit message, fix whitespace]
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
-rw-r--r-- | bus/config-loader-expat.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/bus/config-loader-expat.c b/bus/config-loader-expat.c index b571fda3..90196973 100644 --- a/bus/config-loader-expat.c +++ b/bus/config-loader-expat.c @@ -242,7 +242,7 @@ bus_config_load (const DBusString *file, data_str = _dbus_string_get_const_data (&data); - if (!XML_Parse (expat, data_str, _dbus_string_get_length (&data), TRUE)) + if (XML_Parse (expat, data_str, _dbus_string_get_length (&data), TRUE) == XML_STATUS_ERROR) { if (context.error != NULL && !dbus_error_is_set (context.error)) |