diff options
| author | Nicolas Dufresne <nicolas.dufresne@collabora.com> | 2018-03-07 11:16:00 -0500 |
|---|---|---|
| committer | Nicolas Dufresne <nicolas.dufresne@collabora.com> | 2018-03-07 20:03:56 -0500 |
| commit | 12c5d903c9cf80d9365d57b4643fef9f57aa4d60 (patch) | |
| tree | 870c8ddad4cf1072cacd712cc9cc84be73f30220 | |
| parent | f204b57fa54447d7d0052cd96f0fc5cb76016af6 (diff) | |
basesrc: No need to stop flushing in start_complete
The flushing state is handled a bit differently, there is no need
to stop flushing in start_complete. This would other result in
unlock_stop being called without unlock_start.
Unlike what the old comment says, there is no need to take the live
lock here, we are still single threaded at this point (app thread
or the state change thread). Also, we will wait for playing state
in create/getrange, no need to do that twice.
https://bugzilla.gnome.org/show_bug.cgi?id=794149
| -rw-r--r-- | libs/gst/base/gstbasesrc.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/libs/gst/base/gstbasesrc.c b/libs/gst/base/gstbasesrc.c index da73c8c05..f85f32105 100644 --- a/libs/gst/base/gstbasesrc.c +++ b/libs/gst/base/gstbasesrc.c @@ -3512,10 +3512,6 @@ gst_base_src_start_complete (GstBaseSrc * basesrc, GstFlowReturn ret) GST_DEBUG_OBJECT (basesrc, "is random_access: %d", basesrc->random_access); - /* stop flushing now but for live sources, still block in the LIVE lock when - * we are not yet PLAYING */ - gst_base_src_set_flushing (basesrc, FALSE); - gst_pad_mark_reconfigure (GST_BASE_SRC_PAD (basesrc)); GST_OBJECT_LOCK (basesrc->srcpad); |