diff options
| author | Tobias Jakobi <tjakobi@math.uni-bielefeld.de> | 2015-09-08 17:22:30 +0200 |
|---|---|---|
| committer | Emil Velikov <emil.l.velikov@gmail.com> | 2015-09-21 17:43:14 +0100 |
| commit | 76d1c6b15725f1e7de3c60b0398639e06bf295be (patch) | |
| tree | 38ad33307fe4ac18462ddfdec9899f6ec2acdc51 /exynos | |
| parent | e3c97d1a2473cd06a964599d10465f1e6a4d9015 (diff) | |
exynos/fimg2d: remove default case from g2d_get_blend_op()
We now validate the blending mode via g2d_validate_mode()
prior to feeding it to g2d_get_blend_op().
Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
Diffstat (limited to 'exynos')
| -rw-r--r-- | exynos/exynos_fimg2d.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c index 9d9359ae..d7cbb243 100644 --- a/exynos/exynos_fimg2d.c +++ b/exynos/exynos_fimg2d.c @@ -64,6 +64,11 @@ static unsigned int g2d_get_blend_op(enum e_g2d_op op) val.val = 0; + /* + * The switch statement is missing the default branch since + * we assume that the caller checks the blending operation + * via g2d_validate_blending_op() first. + */ switch (op) { case G2D_OP_CLEAR: case G2D_OP_DISJOINT_CLEAR: @@ -91,11 +96,6 @@ static unsigned int g2d_get_blend_op(enum e_g2d_op op) SET_BF(val, G2D_COEFF_MODE_SRC_ALPHA, 0, 0, 0, G2D_COEFF_MODE_SRC_ALPHA, 1, 0, 0); break; - default: - fprintf(stderr, "Not support operation(%d).\n", op); - SET_BF(val, G2D_COEFF_MODE_ONE, 0, 0, 0, G2D_COEFF_MODE_ZERO, - 0, 0, 0); - break; } return val.val; |