summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Peres <martin.peres@linux.intel.com>2016-01-28 18:37:58 +0200
committerMartin Peres <martin.peres@linux.intel.com>2016-01-28 18:37:58 +0200
commite70edea6ce5cfb21137e736ed25792feae512fd2 (patch)
tree8adc0d6c20241766434c24a3bc20d7811fdf28e1
parent73573acafab3276db0cee38b4f28fa5822dcd828 (diff)
report: rename a class EventInsufficientSignificance
And add some nice helpers along the way!
-rw-r--r--utils/ezbench.py10
1 files changed, 8 insertions, 2 deletions
diff --git a/utils/ezbench.py b/utils/ezbench.py
index 43e004d..ac7348e 100644
--- a/utils/ezbench.py
+++ b/utils/ezbench.py
@@ -1004,11 +1004,17 @@ class EventPerfChange:
self.old_perf, self.new_perf, self.diff() * 100,
self.confidence)
-class EventInsufficientSignificanceResult:
+class EventInsufficientSignificance:
def __init__(self, result, wanted_margin):
self.result = result
self.wanted_margin = wanted_margin
+ def margin(self):
+ return self.result.confidence_margin(self.wanted_margin)[0]
+
+ def wanted_n(self):
+ return self.result.confidence_margin(self.wanted_margin)[1]
+
def __str__(self):
margin, wanted_n = self.result.confidence_margin(self.wanted_margin)
msg = "Benchmark {} on commit {} requires more runs to reach the wanted margin ({:.2f}% vs {:.2f}%), proposes n = {}."
@@ -1065,7 +1071,7 @@ class Report:
current_margin, wanted_n = result.confidence_margin(max_variance)
if current_margin > max_variance:
- self.events.append(EventInsufficientSignificanceResult(result, max_variance))
+ self.events.append(EventInsufficientSignificance(result, max_variance))
if bench in bench_prev:
# We got previous perf results, compare!