diff options
| author | Martin Peres <martin.peres@free.fr> | 2016-01-23 15:38:24 +0200 |
|---|---|---|
| committer | Martin Peres <martin.peres@free.fr> | 2016-01-23 15:38:24 +0200 |
| commit | 651347bf7fca3103b9be1fd52f861bdf5466dbfc (patch) | |
| tree | 327873f4ca88ddb306ee2c0b9c07a6d91baa9d19 | |
| parent | 2da8946e2da1cb77fb6930549234fe296b9537dd (diff) | |
compare_reports: properly escape '"' and de-duplicate the work
| -rwxr-xr-x | stats/compare_reports.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/stats/compare_reports.py b/stats/compare_reports.py index 647a1b3..68969e1 100755 --- a/stats/compare_reports.py +++ b/stats/compare_reports.py @@ -347,6 +347,7 @@ html_template=""" var dataTable = new google.visualization.DataTable(); <%def name="tooltip_commit_table(commit)">\\ +<h3>${db["commits"][commit]['commit'].full_name.replace('"', '"')}</h3>\\ <h4>Commit\\ % if 'commit_url' in db: (<a href='${db["commit_url"].format(commit=commit)}' target='_blank'>URL</a>)\\ @@ -373,7 +374,7 @@ html_template=""" % endfor dataTable.addRows([ % for commit in db["commits"]: - ['${commit}', "<h3>${db["commits"][commit]['commit'].full_name}</h3>${tooltip_commit_table(commit)}<h4>Perf</h4><table>\\ + ['${commit}', "${tooltip_commit_table(commit)}<h4>Perf</h4><table>\\ % for report in db["reports"]: % if report in db["commits"][commit]['reports']: <tr><td><b>${report}:</b></td><td>${db["commits"][commit]['reports'][report]["average"]} ${output_unit}</td></tr>\\ @@ -415,7 +416,7 @@ html_template=""" diff_target = db["commits"][commit]['reports'][report][benchmark].average * 100 / db['targets'][benchmark] diff_target = "{0:.2f}".format(diff_target) %> -, ${diff_target}, "<h3>${db["commits"][commit]['commit'].full_name}</h3>${tooltip_commit_table(commit)}<h4>Perf</h4><table><tr><td><b>Target</b></td><td>${diff_target} %</td></tr><tr><td><b>Raw value</b></td><td>${db["commits"][commit]['reports'][report][benchmark].average} ${output_unit}</td></tr></table>"\\ +, ${diff_target}, "${tooltip_commit_table(commit)}<h4>Perf</h4><table><tr><td><b>Target</b></td><td>${diff_target} %</td></tr><tr><td><b>Raw value</b></td><td>${db["commits"][commit]['reports'][report][benchmark].average} ${output_unit}</td></tr></table>"\\ % else: , null, "${benchmark}"\\ % endif |