summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorbdw-nuc <bdw-nuc@intel.com>2016-01-20 13:11:03 +0200
committerMartin Peres <martin.peres@linux.intel.com>2016-01-20 13:23:14 +0200
commit1d61d7874828394c86de8f3a7dd078652d2a46e5 (patch)
tree84dddcffb12ddaef6816e47eefdac52867992e88
parent806c1fc3f45fc6a89b4006519cd866c8aefd9c4f (diff)
smart_ezbench: fix the auto-bisect, broken by 0e769d56
It got broken by commit: 0e769d56 "ezbench.py/git_history: parse the date along with the sha1"
-rw-r--r--utils/ezbench.py7
1 files changed, 4 insertions, 3 deletions
diff --git a/utils/ezbench.py b/utils/ezbench.py
index 2b917c5..2772b45 100644
--- a/utils/ezbench.py
+++ b/utils/ezbench.py
@@ -623,8 +623,9 @@ class SmartEzbench:
# Generate the report, order commits based on the git history
if git_history is None:
git_history = self.git_history()
+ commits_rev_order = [c.sha1 for c in git_history]
r = genPerformanceReport(self.log_folder, silentMode = True,
- commits_rev_order=[c.sha1 for c in git_history])
+ commits_rev_order=commits_rev_order)
# Check all the commits
bench_prev = dict()
@@ -641,7 +642,7 @@ class SmartEzbench:
msg = "The build got broken"
else:
msg = "The build got fixed"
- middle_commit = self.__find_middle_commit(git_history,
+ middle_commit = self.__find_middle_commit(commits_rev_order,
commit_prev.sha1,
commit.sha1, msg)
if middle_commit is not None:
@@ -682,7 +683,7 @@ class SmartEzbench:
diff < (1 - perf_change_threshold)):
msg = "Bench '{}' went from {} to {} {}".format(bench, round(old_perf, 2),
round(perf, 2), bench_unit)
- middle_commit = self.__find_middle_commit(git_history, old_commit,
+ middle_commit = self.__find_middle_commit(commits_rev_order, old_commit,
commit.sha1, msg)
if middle_commit is not None:
# TODO: Figure out how many runs we need based on the variance