diff options
| author | Thomas Haller <thaller@redhat.com> | 2015-05-10 10:02:31 +0200 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2015-06-17 11:41:43 +0200 |
| commit | 1486cdb1341822685162baa3d38a7862df5b415f (patch) | |
| tree | b12f855fa96e8a3ef7e1c5ff0ad2fedbb9bd5e13 /valgrind.suppressions | |
| parent | c6d46478c8558208a14550d516aa6be5095975f9 (diff) | |
platform: fetch objects via the event socket
Use the event socket to request object via NLM_F_DUMP.
No longer use 'priv->nlh' socket to fetch objects.
Instead fetch them via the priv->nlh_event socket that also
provides asynchronous events when objects change.
That way, the events are in sync with our explicit requests
and we can directly use the events. Previously, the events were
only used to indicate that a refetch must happen, so that every
event triggered a complete dump of all addresses/routes.
We still use 'priv->nlh' to make synchronous requests such as
adding/changing/deleting objects. That means, after we send a
request, we must make sure that the result manifested itself
at 'nlh_event' socket and the platform cache.
That's why we sometimes still must force a dump to sync changes.
That could be improved by using only one netlink socket so that
we would wait for the ACK of our request.
While not yet perfect, this already significantly reduces the number of
fetches. Additionally, before, whenever requesting a dump of addresses
or routes (which we did much more often, search for "get_kernel_object for type"
log lines), we always dumped IPv4 and IPv6 together. Now only request
the addr-family in question.
https://bugzilla.gnome.org/show_bug.cgi?id=747985
https://bugzilla.redhat.com/show_bug.cgi?id=1211133
Diffstat (limited to 'valgrind.suppressions')
| -rw-r--r-- | valgrind.suppressions | 18 |
1 files changed, 0 insertions, 18 deletions
diff --git a/valgrind.suppressions b/valgrind.suppressions index 6bcd4c9d0..5a345fd93 100644 --- a/valgrind.suppressions +++ b/valgrind.suppressions @@ -419,24 +419,6 @@ { # fixed by https://github.com/thom311/libnl/commit/d65c32a7205e679c7fc13f0e4565b13e698ba906 - libnl_rtnl_link_set_type_01 - Memcheck:Leak - match-leak-kinds: definite - fun:calloc - fun:vlan_alloc - fun:rtnl_link_set_type - fun:link_msg_parser - fun:__pickup_answer - fun:nl_cb_call - fun:recvmsgs - fun:nl_recvmsgs_report - fun:nl_recvmsgs - fun:nl_pickup - fun:rtnl_link_get_kernel - ... -} -{ - # fixed by https://github.com/thom311/libnl/commit/d65c32a7205e679c7fc13f0e4565b13e698ba906 # Same issue as libnl_rtnl_link_set_type_01, but different backtrace by calling nl_msg_parse(). libnl_rtnl_link_set_type_02 Memcheck:Leak |