diff options
author | Thomas Haller <thaller@redhat.com> | 2018-11-18 11:48:44 +0100 |
---|---|---|
committer | Thomas Haller <thaller@redhat.com> | 2018-11-18 11:59:47 +0100 |
commit | 6f28f4b661e8938c42951a8135bc0d6710978dfb (patch) | |
tree | 09732d01138a35cb2cf436b306c35d85d9a97402 /introspection | |
parent | f10f0199826ea8b7b818bfe5e8268b4f4839a493 (diff) |
manager: allow add-and-activate option "bind" with non-volatile profiles
For one, there was a bug here: we cannot "goto error" without setting
the @error variable.
Anyway, restricting "bind" "dbus-client" only to profiles that are
"persist" mode "volatile" seems wrong. The "bind" option as it is,
limits the lifetime of the active-connection. This has no direct relation
with the lifetime of the setting-connection. Indeed, if the
settings-connection's lifetime is itself set to "volatile", then
it will indeed go away with the active-connection. However, these
two concepts are not strictly related.
In the future, we might add an option to limite the lifetime of
a settings-connection to a D-Bus client ("bind-setting"). Possibly
we should thus rename "bind" to "bind-activation", to make the
distinction clearer.
Diffstat (limited to 'introspection')
-rw-r--r-- | introspection/org.freedesktop.NetworkManager.xml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/introspection/org.freedesktop.NetworkManager.xml b/introspection/org.freedesktop.NetworkManager.xml index 715e182ed..f78a989a4 100644 --- a/introspection/org.freedesktop.NetworkManager.xml +++ b/introspection/org.freedesktop.NetworkManager.xml @@ -129,7 +129,7 @@ parameters. At this time the following options are supported: * persist: A string value of either "disk" (default), "memory" or "volatile". If "memory" is passed, the connection will not be saved to disk. If "volatile" is passed, the connection will not be saved to disk and will be destroyed when disconnected. - * bind: Bind the connections lifetime. Set to "dbus-name" to automatically disconnect when the requesting process disappears from the bus. The default of "none" means the connection is kept alive normally. If restricted, then persist must be set to "volatile". + * bind: Bind the activation lifetime. Set to "dbus-name" to automatically disconnect when the requesting process disappears from the bus. The default of "none" means the connection is kept activated normally. --> <method name="AddAndActivateConnection2"> <arg name="connection" type="a{sa{sv}}" direction="in"/> |