Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
|
|
|
|
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
|
|
Cc: Jason Ekstrand <jason@jlekstrand.net>
Cc: Mark Janes <mark.a.janes@intel.com>
|
|
We have recently found a regression in the i965 driver related to
gl_PointCoord which was not being caught by this test. This patch
changes the test slightly so that we can expose the problem for
future regression testing.
The problem occured because the driver was not using the correct
number of FS inputs to to program a certain piece of HW state, as
it did not account for some inputs that require special treatment,
such as gl_PointCoord.
However, this test was not able to find this because the hardware
also has a restriction by which it needs to program, at least,
2 FS inputs, so if we only have gl_PointCoord as input, which is
what we had here, it would still work.
This patch adds a couple of additional varyings so we have 3
inputs in total, ensuring that we trigger the problem.
Besides this, it also removes a sampler uniform that was not used
in the fragment shader, and includes the GLSL version that was
missing in the vertex shader.
|
|
After:
https://github.com/KhronosGroup/VK-GL-CTS/commit/f06134c65f55a009bbe284d2b7c0e56dee0f70cd
The Khronos CTS runner added a new KHR-NoContext case list.
This new test profile will run this new subset.
Cc: Mark Janes <mark.a.janes@intel.com>
Cc: Dylan Baker <dylanx.c.baker@intel.com>
Cc: Juan A. Suarez Romero <jasuarez@igalia.com>
Signed-off-by: Andres Gomez <agomez@igalia.com>
Reviewed-by: Juan A. Suarez <jasuarez@igalia.com>
Acked-by: Dylan Baker <dylan@pnwbakers.com>
|
|
OpenGL GLES*-CTS case lists were renamed to KHR-GLES* in the upstream
repository.
We want to keep the existing profiles so we are able to keep running
the caselists from previous CTS releases and for branches in the open
sourced repository created for API-specific release branches, as
explained at:
https://github.com/KhronosGroup/VK-GL-CTS/wiki/Contributing#branches
Therefore, we add this new test profile to be able to run the renamed
tests in the master branch of the opensourced Khronos CTS tests at:
https://github.com/KhronosGroup/VK-GL-CTS
Cc: Mark Janes <mark.a.janes@intel.com>
Cc: Dylan Baker <dylanx.c.baker@intel.com>
Cc: Juan A. Suarez Romero <jasuarez@igalia.com>
Signed-off-by: Andres Gomez <agomez@igalia.com>
Reviewed-by: Juan A. Suarez <jasuarez@igalia.com>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
|
|
SAMPLES and NUM_SAMPLE_COUNTS queries accept internalformats which
are defined as color-, depth- or stencil-renderable. RGB9_E5 is marked
as non color-renderable in OpenGL 4.6, however if the
EXT_texture_shared_exponent extension is exposed it must be considered
as such. The later was discussed in:
https://github.com/KhronosGroup/OpenGL-API/issues/32
v2: use 'tex' as shortname for texture instead of 'text' (Piñeiro)
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104794
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
|
|
This test was randomly passing on r600 due to not clearing the contents.
|
|
The function is supposed to return a piglit_result, not true/false.
Fixes incorrect 'fail' results.
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
|
|
and glGetStringi(GL_SHADING_LANGUAGE_VERSION, i) queries in GL 4.3.
Until recently, these queries were not implemented in Mesa.
Tested-by: Andriy.Khulap <andriy.khulap@globallogic.com>
|
|
Both with and without display lists.
|
|
Both with and without display lists.
|
|
Both with and without display lists.
|
|
The GL limit is MaxTextureCombinedUnits, but the real usable limit is
MaxTextureCoordUnits. This is probably a spec bug.
Mesa will ignore glTexEnv calls where unit >= MaxTextureCoordUnits.
Reviewed-by: Brian Paul <brianp@vmware.com>
|
|
Mesa will not use doubles for this state.
Reviewed-by: Brian Paul <brianp@vmware.com>
|
|
Fixes: 86e9ebaaf8eeb35161650ded11c1c51bf75973d9 ("cl: Add test for MUBUF access with a negative vaddr")
Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
|
|
The test can now take an extra argument ‘indirect’ which will cause
it to emit the draw calls via an indirect buffer. This is useful to
test at least on i965 because emitting the gl_BaseVertex takes a
different path in that case.
Reviewed-by: Antia Puentes <apuentes@igalia.com>
|
|
The ‘first’ parameter should not affect the value of gl_BaseVertex but
it should be added to gl_VertexID. This patch adds an extra rectangle
to the drawn area to test a non-zero ‘first’ parameter. This is worth
testing because Mesa is currently getting this wrong.
Reviewed-by: Antia Puentes <apuentes@igalia.com>
|
|
This is a workaround for a larger bug, but this is easy to apply and
fixes the output of tests.
Signed-off-by: Dylan Baker <dylan.c.baker@intel.com>
Reviewed-by: Mark Janes <mark.a.janes@intel.com>
|
|
Cc: Kenneth Graunke <kenneth@whitecape.org>
Cc: Dylan Baker <dylan@pnwbakers.com>
Signed-off-by: Andres Gomez <agomez@igalia.com>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
|
|
Until now we were only running the python unit tests.
It seems desirable to also check that the CMake based build compiles
successfully. We do that now using docker.
The docker build can be tweaked with some environment variables and,
also, be stored in the docker hub if desired. Check the changes for
extra details regarding these variables.
v2: Removed other build possibilities other than just from inside
Travis-CI, as suggested by Juan.
v3: Replaced the "RELEASE" parameter to create the docker image with
"PARENT" and removed some unneeded documentation after v2, as
suggested by Juan.
v4:
- Use DOCKER_PARENT, DOCKER_IMAGE and DOCKER_TAG variables from the
custom Travis-CI setup to define the PARENT, IMAGE and TAG
parameters during the docker image creation.
- Upload the image only if DOCKER_IMAGE and DOCKER_TAG are set.
Cc: Dylan Baker <dylan@pnwbakers.com>
Cc: Juan A. Suarez <jasuarez@igalia.com>
Signed-off-by: Andres Gomez <agomez@igalia.com>
Reviewed-by: Juan A. Suarez <jasuarez@igalia.com>
Acked-by: Eric Anholt <eric@anholt.net>
Acked-by: Dylan Baker <dylan@pnwbakers.com>
|
|
The spec says with msaa disabled gl_SampleMaskIn is always 1.
This is not particularly related to arb_sample_shading, but drivers may
do different workarounds depending on the state of sample shading and
presence of bits in the shader which would force per-sample execution,
so it seems appropriate to test here.
At least r600/eg will fail (the hw will give the coverage mask for the,
pixel, not the coverage per sample or 1 if msaa is disabled).
Since the existing partition test could only be passed when giving the
wrong answer for this, I would expect more drivers to fail...
This also fixes the partition test with msaa disabled, as it expected a
wrong gl_SampleMaskIn value in this case (now omit the test in this
case, since it's quite likely multiple things are failing in
the test simultaneously and then the failures can't be distinguished -
the new test for this also doesn't require atomics).
Reviewed-by: Brian Paul <brianp@vmware.com>
|
|
I believe querying that information for GL_TEXTURE_BUFFFER via internal format
query should return the correct values, but it's definitely impossible if just
ARB_texture_buffer_object is supported but not GL 3.1. Hence just pretend it
succeeded in this case. (Also see the corresponding mesa change.)
|
|
Signed-off-by: Fabian Bieler <fabianbieler@fastmail.fm>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
|
|
Signed-off-by: Fabian Bieler <fabianbieler@fastmail.fm>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
|
|
Signed-off-by: Fabian Bieler <fabianbieler@fastmail.fm>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
|
|
Signed-off-by: Fabian Bieler <fabianbieler@fastmail.fm>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
|
|
Because we always want to have the same number of subtests printed, or
they'll show up as "NOTRUN" instead of "SKIP" in the summary.
Signed-off-by: Dylan Baker <dylan.c.baker@intel.com>
Reviewed-by: Fabian Bieler <fabianbieler@fastmail.fm>
|
|
Currently the name of the subtest relies on checking the GL state of the
command to know whether the framebuffer is completely or incomplete.
That is a problem for enumerating subtests, we would need to know ahead
of time whether the framebuffer is complete or not.
Instead print the completeness of the test apart from the subtest name,
and name the subtest name just the format name. This also makes the name
the same when the test fails and when in passes.
Signed-off-by: Dylan Baker <dylan.c.baker@intel.com>
Reviewed-by: Fabian Bieler <fabianbieler@fastmail.fm>
|
|
!skip -> skip won't show up in the regressions/fixes/etc lists anyway,
and this means that the output will always be the same.
Signed-off-by: Fabian Bieler <fabianbieler@fastmail.fm>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
|
|
Signed-off-by: Fabian Bieler <fabianbieler@fastmail.fm>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
|
|
This gives us something to test the python part against.
Signed-off-by: Fabian Bieler <fabianbieler@fastmail.fm>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
|
|
This relies on the fact that subtests are guaranteed to be ordered to
mark the crashing subtest as such. This ensures that the correct status
will be propagated up the totals tree.
Signed-off-by: Fabian Bieler <fabianbieler@fastmail.fm>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
|
|
This adds support for enumerating subtests to the python layer. When it
sees this it sets each subtest to notrun. This allows the python
framework to report that tests didn't run when they were expected to.
Signed-off-by: Dylan Baker <dylan.c.baker@intel.com>
Reviewed-by: Fabian Bieler <fabianbieler@fastmail.fm>
|
|
This is a small cleanup, but we need to touch this code further for
subtest enumeration work, and we'll want to use statuses there too.
Signed-off-by: Fabian Bieler <fabianbieler@fastmail.fm>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
|
|
This makes the order of the subtests deterministic. Since piglit test
binaries are expected to enumerate subtests in the same order that
they'll run them this will allow us to know which subtest crashed when
there is a crash.
Signed-off-by: Fabian Bieler <fabianbieler@fastmail.fm>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
|
|
This function takes one or more subtests as strings and prints a JSON
structure that the python framework can consume.
Signed-off-by: Fabian Bieler <fabianbieler@fastmail.fm>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
|
|
For informing the python framework of the number and order of subtests
that will be run.
Signed-off-by: Fabian Bieler <fabianbieler@fastmail.fm>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
|
|
If wflinfo is not installed or fails, the wfl_info.gl_extensions value
will be the empty set. Similarly, the gl_version, glsl_version, etc.
will be None.
In those cases, return True from the gl_extension_supported() and
is_feature_directory_supported() functions so that we don't skip any
subdirs.
This is only relevant when PIGLIT_FILTER_DIRECTORIES is set.
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
|
|
Seems overkill to write a brand new test just for this so add it to
the existing invalid-formats.c test.
See Bugzilla https://bugs.freedesktop.org/show_bug.cgi?id=104908
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
|
|
Reviewed-by: Fabian Bieler <fabianbieler@fastmail.fm>
|
|
Explanation in test comment.
Reviewed-by: Jan Vesely <jan.vesely@rutgers.edu>
|
|
The spec doesn't define any errors for ext_memory_object_fd, but do at
least a basic sanity test.
Signed-off-by: Andres Rodriguez <andresx7@gmail.com>
|
|
The spec doesn't define any errors for ext_semaphore_fd, but do at
least a basic sanity test.
Signed-off-by: Andres Rodriguez <andresx7@gmail.com>
|
|
Calling piglit_check_gl_error() already dumps the relevant debug
information to stdout.
Signed-off-by: Andres Rodriguez <andresx7@gmail.com>
|
|
Signed-off-by: Andres Rodriguez <andresx7@gmail.com>
|
|
On those cases, the resource is not supported, so we should expect the
unsupported outcome.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
|