diff options
| author | Eric Engestrom <eric.engestrom@intel.com> | 2018-05-08 16:40:24 +0100 |
|---|---|---|
| committer | Eric Engestrom <eric.engestrom@intel.com> | 2018-05-14 14:55:36 +0100 |
| commit | f0cdc39b134dfc38f84b0f6dc1eaad86d28d4170 (patch) | |
| tree | 63d5b3ddbea96004a20203f91a30b98bd278604a | |
| parent | ece398277cf1de5ac4debfd9855909fd1bafb239 (diff) | |
meson: remove dependency antipattern
`dep_valgrind != []` now (0.45) produces a warning that is quite explicit:
WARNING: Trying to compare values of different types (DependencyHolder, list) using !=.
The result of this is undefined and will become a hard error in a future Meson release.
`dep_valgrind = []` used to be the recommended way to deal with
non-existant dependency, but these don't work with `.found()`, so now
the recommended way is to declare a impossible dependency, which
null_dep does for us in Mesa.
In short, we don't need and shouldn't check for `!= []` anywhere anymore.
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
Signed-off-by: Eric Engestrom <eric.engestrom@intel.com>
| -rw-r--r-- | src/compiler/glsl/glcpp/meson.build | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/compiler/glsl/glcpp/meson.build b/src/compiler/glsl/glcpp/meson.build index e6a3dc8675..09d44ddd68 100644 --- a/src/compiler/glsl/glcpp/meson.build +++ b/src/compiler/glsl/glcpp/meson.build @@ -57,7 +57,7 @@ glcpp = executable( if with_tests modes = ['unix', 'windows', 'oldmac', 'bizarro'] - if dep_valgrind != [] and dep_valgrind.found() + if dep_valgrind.found() modes += ['valgrind'] endif |