Bug #11397: check that numeric --orientation arguments are in range

The only valid parameters to -o (--orientation) are 0, 1, 2, 3, normal, left,
inverted, and right.  xrandr converts the strings to numbers and then checks
that they're within range, but doesn't validate them if it was numeric to begin
with.

Move the range check outside of the if statement so that out-of-range numeric
values are rejected properly.

Signed-off-by: Aaron Plattner <aplattner@nvidia.com>
Reviewed-by: Daniel Dadap <ddadap@nvidia.com>

1 files changed, 1 insertions, 1 deletions

diff --git a/xrandr.c b/xrandr.c
index b0e8cec..926bc68 100644
--- a/xrandr.c
+++ b/xrandr.c
@@ -2579,8 +2579,8 @@ main (int argc, char **argv)
 		for (dirind = 0; dirind < 4; dirind++) {
 		    if (strcmp (direction[dirind], argv[i]) == 0) break;
 		}
-		if ((dirind < 0) || (dirind > 3))  usage();
 	    }
+	    if ((dirind < 0) || (dirind > 3))  usage();
 	    rot = dirind;
 	    setit = True;
 	    action_requested = True;